jenkins-bot has submitted this change and it was merged.
Change subject: Dim the title of current wiki if it has 0 notifications
......................................................................
Dim the title of current wiki if it has 0 notifications
Bug: T139646
Change-Id: I827cb43d5badd0a13666226691450a73ddcc85ea
---
M modules/styles/mw.echo.ui.PageNotificationsOptionWidget.less
M modules/ui/mw.echo.ui.PageNotificationsOptionWidget.js
2 files changed, 8 insertions(+), 0 deletions(-)
Approvals:
Mattflaschen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/styles/mw.echo.ui.PageNotificationsOptionWidget.less
b/modules/styles/mw.echo.ui.PageNotificationsOptionWidget.less
index 1966d9d..b07752b 100644
--- a/modules/styles/mw.echo.ui.PageNotificationsOptionWidget.less
+++ b/modules/styles/mw.echo.ui.PageNotificationsOptionWidget.less
@@ -12,6 +12,13 @@
}
}
+ &-empty {
+ .mw-echo-ui-pageNotificationsOptionWidget-count,
+ .mw-echo-ui-pageNotificationsOptionWidget-title-label {
+ color: @grey-light;
+ }
+ }
+
&-title {
padding: 0.2em 0;
}
diff --git a/modules/ui/mw.echo.ui.PageNotificationsOptionWidget.js
b/modules/ui/mw.echo.ui.PageNotificationsOptionWidget.js
index e3283f4..4cc8b41 100644
--- a/modules/ui/mw.echo.ui.PageNotificationsOptionWidget.js
+++ b/modules/ui/mw.echo.ui.PageNotificationsOptionWidget.js
@@ -31,6 +31,7 @@
// Initialization
this.$element
.addClass( 'mw-echo-ui-pageNotificationsOptionWidget' )
+ .toggleClass(
'mw-echo-ui-pageNotificationsOptionWidget-empty', !this.count )
.append(
$( '<div>' )
.addClass(
'mw-echo-ui-pageNotificationsOptionWidget-count' )
--
To view, visit https://gerrit.wikimedia.org/r/299189
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I827cb43d5badd0a13666226691450a73ddcc85ea
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
