JGirault has uploaded a new change for review.
https://gerrit.wikimedia.org/r/299267
Change subject: Remove map param from addDataLayer signature (redundant)
......................................................................
Remove map param from addDataLayer signature (redundant)
Change-Id: I1ee60cb27d28886600cf8809026ca194b2a6a154
---
M modules/live/MWMap.js
1 file changed, 3 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Kartographer
refs/changes/67/299267/1
diff --git a/modules/live/MWMap.js b/modules/live/MWMap.js
index 7b7491b..f53aef5 100644
--- a/modules/live/MWMap.js
+++ b/modules/live/MWMap.js
@@ -192,7 +192,7 @@
getMapGroupData( data.overlays ).then( function ( mapData ) {
$.each( data.overlays, function ( index, group ) {
if ( !$.isEmptyObject( mapData[ group ] ) ) {
- map.dataLayers[ group ] =
self.addDataLayer( map, mapData[ group ] );
+ map.dataLayers[ group ] =
self.addDataLayer( mapData[ group ] );
} else {
mw.log.warn( 'Layer not found or
contains no data: "' + group + '"' );
}
@@ -302,12 +302,11 @@
};
/**
- * Create a new GeoJSON layer and add it to map.
+ * Creates a new GeoJSON layer and adds it to the map.
*
- * @param {L.Map} map Map to get layers from
* @param {Object} geoJson
*/
- MWMap.prototype.addDataLayer = function ( map, geoJson ) {
+ MWMap.prototype.addDataLayer = function ( geoJson ) {
try {
return L.mapbox.featureLayer( geoJson, dataLayerOpts
).addTo( this.map );
} catch ( e ) {
--
To view, visit https://gerrit.wikimedia.org/r/299267
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ee60cb27d28886600cf8809026ca194b2a6a154
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Kartographer
Gerrit-Branch: master
Gerrit-Owner: JGirault <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
