Matěj Suchánek has uploaded a new change for review.
https://gerrit.wikimedia.org/r/299282
Change subject: Optimize DiscussionParser.php
......................................................................
Optimize DiscussionParser.php
Change-Id: I57c422d4c276062d4d55c9a8f580a22ef318f732
---
M includes/DiscussionParser.php
1 file changed, 4 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/82/299282/1
diff --git a/includes/DiscussionParser.php b/includes/DiscussionParser.php
index 571ed87..cd0cf5e 100644
--- a/includes/DiscussionParser.php
+++ b/includes/DiscussionParser.php
@@ -15,8 +15,6 @@
* @return null
*/
static function generateEventsForRevision( Revision $revision ) {
- $interpretation = self::getChangeInterpretationForRevision(
$revision );
-
// use slave database if there is a previous revision
if ( $revision->getPrevious() ) {
$title = Title::newFromID( $revision->getPage() );
@@ -29,6 +27,8 @@
if ( !$title ) {
return;
}
+
+ $interpretation = self::getChangeInterpretationForRevision(
$revision );
$userID = $revision->getUser();
$userName = $revision->getUserText();
@@ -400,14 +400,12 @@
}
// And then forwards...
-
- $continue = true;
$i = $offset - 1;
- while ( $continue && $i < count( $lines ) - 1 ) {
+ while ( $i < count( $lines ) - 1 ) {
++$i;
$line = $lines[$i];
if ( preg_match( $headerRegex, $line ) ) {
- $continue = false;
+ break;
} else {
$content .= "\n$line";
}
--
To view, visit https://gerrit.wikimedia.org/r/299282
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I57c422d4c276062d4d55c9a8f580a22ef318f732
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Matěj Suchánek <matejsuchane...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
