jenkins-bot has submitted this change and it was merged.
Change subject: Log json_encode errors
......................................................................
Log json_encode errors
When completed donation logging fails, we want to know what's up.
TODO: Write a test for this.
Bug: T140515
Change-Id: I38a330f3f324f9a0a6b072b43d4e841b0d483128
---
M gateway_common/gateway.adapter.php
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Awight: Looks good to me, approved
jenkins-bot: Verified
diff --git a/gateway_common/gateway.adapter.php
b/gateway_common/gateway.adapter.php
index f294885..a90be82 100644
--- a/gateway_common/gateway.adapter.php
+++ b/gateway_common/gateway.adapter.php
@@ -3723,6 +3723,11 @@
// as getStompTransaction, but I'm currently debugging
that
// function, so dump it all:
$dump = json_encode( $this->getData_Unstaged_Escaped()
);
+ if ( $dump === false ) {
+ // Encoding failed. Why?
+ // TODO: Reuse this in logPaymentDetails.
+ $dump = json_encode( array( 'json_encode_error'
=> json_last_error() . ': ' . json_last_error_msg() ) );
+ }
$this->logger->info( self::COMPLETED_PREFACE . $dump );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/299302
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I38a330f3f324f9a0a6b072b43d4e841b0d483128
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: deployment
Gerrit-Owner: Awight <awi...@wikimedia.org>
Gerrit-Reviewer: AndyRussG <andrew.green...@gmail.com>
Gerrit-Reviewer: Awight <awi...@wikimedia.org>
Gerrit-Reviewer: Cdentinger <cdentin...@wikimedia.org>
Gerrit-Reviewer: Ejegg <eeggles...@wikimedia.org>
Gerrit-Reviewer: Ssmith <ssm...@wikimedia.org>
Gerrit-Reviewer: XenoRyet <dkozlow...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
