jenkins-bot has submitted this change and it was merged.
Change subject: Check Title.newFromImg produced a valid title with an extension
......................................................................
Check Title.newFromImg produced a valid title with an extension
Bug: T140574
Change-Id: Ia818cebd47b3bce03befc547e5e435cb8b1f2996
---
M resources/mmv/mmv.bootstrap.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
MarkTraceur: Looks good to me, approved
Jforrester: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/resources/mmv/mmv.bootstrap.js b/resources/mmv/mmv.bootstrap.js
index 8700330..5d972fd 100644
--- a/resources/mmv/mmv.bootstrap.js
+++ b/resources/mmv/mmv.bootstrap.js
@@ -180,7 +180,7 @@
link = $link.prop( 'href' ),
alt = $thumb.attr( 'alt' );
- if ( !( title.getExtension().toLowerCase() in
bs.validExtensions ) ) {
+ if ( !title || !title.getExtension() || !(
title.getExtension().toLowerCase() in bs.validExtensions ) ) {
return;
}
--
To view, visit https://gerrit.wikimedia.org/r/299531
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia818cebd47b3bce03befc547e5e435cb8b1f2996
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: MarkTraceur <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
