ArielGlenn has submitted this change and it was merged.
Change subject: never write run settings unless we are actually running dump
jobs
......................................................................
never write run settings unless we are actually running dump jobs
Previously, a simple check of dump job status could trigger a write
of the run settings cache if the cache did not already exist. This
could happen without alock, for example.
Change-Id: I1fd059582fe97e56d7e7712542a86b48aea38124
---
M xmldumps-backup/worker.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
ArielGlenn: Looks good to me, approved
jenkins-bot: Verified
diff --git a/xmldumps-backup/worker.py b/xmldumps-backup/worker.py
index 51aaa6a..e09c88b 100644
--- a/xmldumps-backup/worker.py
+++ b/xmldumps-backup/worker.py
@@ -117,7 +117,7 @@
if check_job_status:
if check_jobs(wiki, date, job, skipjobs, page_id_range,
partnum_todo, checkpoint_file, restart,
- prefetch, prefetchdate, spawn, dryrun,
+ prefetch, prefetchdate, spawn, True,
skipdone, verbose, html_notice):
continue
try:
@@ -131,7 +131,7 @@
# there are still wikis where this job needs to run
if not check_jobs(wiki, date, job, skipjobs, page_id_range,
partnum_todo,
checkpoint_file, prefetch, prefetchdate,
- spawn, dryrun, skipdone, verbose,
+ spawn, True, skipdone, verbose,
html_notice, prereqs=True, restart=restart):
missing_prereqs = True
sys.stderr.write("Couldn't lock %s, someone else must have got
it...\n" % dbname)
--
To view, visit https://gerrit.wikimedia.org/r/300034
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1fd059582fe97e56d7e7712542a86b48aea38124
Gerrit-PatchSet: 2
Gerrit-Project: operations/dumps
Gerrit-Branch: master
Gerrit-Owner: ArielGlenn <[email protected]>
Gerrit-Reviewer: ArielGlenn <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
