Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/300093
Change subject: resourceloader: Remove deprecated
ResourceLoader::makeLoaderURL()
......................................................................
resourceloader: Remove deprecated ResourceLoader::makeLoaderURL()
Deprecated since MediaWiki 1.24. Not used anywhere in Wikimedia Git.
Change-Id: I9d9b356fd61f13112e85cbe659b337ecb3c92088
---
M RELEASE-NOTES-1.28
M includes/resourceloader/ResourceLoader.php
2 files changed, 2 insertions(+), 29 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/93/300093/1
diff --git a/RELEASE-NOTES-1.28 b/RELEASE-NOTES-1.28
index 8b00d2e..08ed8a1 100644
--- a/RELEASE-NOTES-1.28
+++ b/RELEASE-NOTES-1.28
@@ -68,6 +68,7 @@
* Deprecated APIEditBeforeSave hook in favor of EditFilterMergedContent.
* The 'UploadVerification' hook is deprecated. Use 'UploadVerifyFile' instead.
* SiteConfiguration::isLocalVHost() was removed (deprecated since 1.25).
+* ResourceLoader::makeLoaderURL() was removed (deprecated since 1.24).
== Compatibility ==
diff --git a/includes/resourceloader/ResourceLoader.php
b/includes/resourceloader/ResourceLoader.php
index ccf764b..37b31d1 100644
--- a/includes/resourceloader/ResourceLoader.php
+++ b/includes/resourceloader/ResourceLoader.php
@@ -1469,34 +1469,6 @@
}
/**
- * Build a load.php URL
- * @deprecated since 1.24 Use createLoaderURL() instead
- * @param array $modules Array of module names (strings)
- * @param string $lang Language code
- * @param string $skin Skin name
- * @param string|null $user User name. If null, the &user= parameter is
omitted
- * @param string|null $version Versioning timestamp
- * @param bool $debug Whether the request should be in debug mode
- * @param string|null $only &only= parameter
- * @param bool $printable Printable mode
- * @param bool $handheld Handheld mode
- * @param array $extraQuery Extra query parameters to add
- * @return string URL to load.php. May be protocol-relative if
$wgLoadScript is, too.
- */
- public static function makeLoaderURL( $modules, $lang, $skin, $user =
null,
- $version = null, $debug = false, $only = null, $printable =
false,
- $handheld = false, $extraQuery = []
- ) {
- global $wgLoadScript;
-
- $query = self::makeLoaderQuery( $modules, $lang, $skin, $user,
$version, $debug,
- $only, $printable, $handheld, $extraQuery
- );
-
- return wfAppendQuery( $wgLoadScript, $query );
- }
-
- /**
* Helper for createLoaderURL()
*
* @since 1.24
@@ -1522,7 +1494,7 @@
/**
* Build a query array (array representation of query string) for
load.php. Helper
- * function for makeLoaderURL().
+ * function for createLoaderQuery().
*
* @param array $modules
* @param string $lang
--
To view, visit https://gerrit.wikimedia.org/r/300093
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d9b356fd61f13112e85cbe659b337ecb3c92088
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
