jenkins-bot has submitted this change and it was merged.
Change subject: tests: Remove unused params to ResourceLoader::makeLoaderQuery
......................................................................
tests: Remove unused params to ResourceLoader::makeLoaderQuery
The last three parameters (printable, handheld, extraQuery) aren't relevant
here. Also, why was it passing printable=true?
Change-Id: I16dcd8c86b53c6854b0a1a70bf0c1705d40b3b37
---
M tests/ResourceLoaderGlobalModuleTestCase.php
1 file changed, 1 insertion(+), 4 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/ResourceLoaderGlobalModuleTestCase.php
b/tests/ResourceLoaderGlobalModuleTestCase.php
index 23b26d3..07a5c03 100644
--- a/tests/ResourceLoaderGlobalModuleTestCase.php
+++ b/tests/ResourceLoaderGlobalModuleTestCase.php
@@ -44,10 +44,7 @@
$options['user'],
null, // version
false, // debug
- ResourceLoaderModule::TYPE_COMBINED,
- true, // printable
- false, // handheld
- [] // extra
+ ResourceLoaderModule::TYPE_COMBINED
);
$rl = new ResourceLoader(
ConfigFactory::getDefaultInstance()->makeConfig( 'main' ) );
return new ResourceLoaderContext( $rl, new FauxRequest( $query
) );
--
To view, visit https://gerrit.wikimedia.org/r/300089
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I16dcd8c86b53c6854b0a1a70bf0c1705d40b3b37
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GlobalCssJs
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
