jenkins-bot has submitted this change and it was merged. Change subject: pass codesniffer on tests/ ......................................................................
pass codesniffer on tests/ Fix almost all occurences of the following sniffs: Generic.CodeAnalysis.UselessOverridingMethod.Found Generic.Formatting.NoSpaceAfterCast.SpaceFound Generic.Functions.FunctionCallArgumentSpacing.SpaceBeforeComma Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine Generic.PHP.LowerCaseConstant.Found PSR2.Classes.PropertyDeclaration.ScopeMissing PSR2.Files.EndFileNewline.TooMany PSR2.Methods.MethodDeclaration.StaticBeforeVisibility Change-Id: I96aacef5bafe5a2bca659744fba1380999cfc37d --- M tests/phpunit/MediaWikiPHPUnitCommand.php M tests/phpunit/MediaWikiTestCase.php M tests/phpunit/data/xmp/gps.result.php M tests/phpunit/includes/BlockTest.php M tests/phpunit/includes/DiffHistoryBlobTest.php M tests/phpunit/includes/ExternalStoreTest.php M tests/phpunit/includes/ExtraParserTest.php M tests/phpunit/includes/FormOptionsInitializationTest.php M tests/phpunit/includes/FormOptionsTest.php M tests/phpunit/includes/GlobalFunctions/GlobalTest.php M tests/phpunit/includes/GlobalFunctions/wfGetCallerTest.php M tests/phpunit/includes/HooksTest.php M tests/phpunit/includes/HttpTest.php M tests/phpunit/includes/IPTest.php M tests/phpunit/includes/LinksUpdateTest.php M tests/phpunit/includes/LocalFileTest.php M tests/phpunit/includes/MWNamespaceTest.php M tests/phpunit/includes/RevisionStorageTest.php M tests/phpunit/includes/RevisionStorageTest_ContentHandlerUseDB.php M tests/phpunit/includes/RevisionTest.php M tests/phpunit/includes/SampleTest.php M tests/phpunit/includes/SanitizerTest.php M tests/phpunit/includes/SeleniumConfigurationTest.php M tests/phpunit/includes/SiteConfigurationTest.php M tests/phpunit/includes/TimestampTest.php M tests/phpunit/includes/UserTest.php M tests/phpunit/includes/WikiPageTest.php M tests/phpunit/includes/WikiPageTest_ContentHandlerUseDB.php M tests/phpunit/includes/api/ApiTestCaseUpload.php M tests/phpunit/includes/api/format/ApiFormatPhpTest.php M tests/phpunit/includes/api/generateRandomImages.php M tests/phpunit/includes/content/ContentHandlerTest.php M tests/phpunit/includes/db/DatabaseSQLTest.php M tests/phpunit/includes/db/DatabaseSqliteTest.php M tests/phpunit/includes/db/DatabaseTest.php M tests/phpunit/includes/db/ORMRowTest.php M tests/phpunit/includes/filebackend/FileBackendTest.php M tests/phpunit/includes/filerepo/StoreBatchTest.php M tests/phpunit/includes/libs/GenericArrayObjectTest.php M tests/phpunit/includes/logging/LogTests.i18n.php M tests/phpunit/includes/media/ExifRotationTest.php M tests/phpunit/includes/media/MediaHandlerTest.php M tests/phpunit/includes/media/SVGMetadataExtractorTest.php M tests/phpunit/includes/objectcache/BagOStuffTest.php M tests/phpunit/includes/parser/MagicVariableTest.php M tests/phpunit/includes/parser/MediaWikiParserTest.php M tests/phpunit/includes/parser/ParserMethodsTest.php M tests/phpunit/includes/parser/PreprocessorTest.php M tests/phpunit/includes/site/SiteListTest.php M tests/phpunit/includes/site/SiteTest.php M tests/phpunit/includes/site/TestSites.php M tests/phpunit/includes/specials/SpecialRecentchangesTest.php M tests/phpunit/includes/specials/SpecialSearchTest.php M tests/phpunit/languages/LanguageMlTest.php M tests/phpunit/languages/LanguageTest.php M tests/phpunit/languages/utils/CLDRPluralRuleEvaluatorTest.php M tests/phpunit/maintenance/DumpTestCase.php M tests/phpunit/maintenance/MaintenanceTest.php M tests/phpunit/maintenance/backupTextPassTest.php M tests/phpunit/maintenance/backup_LogTest.php M tests/phpunit/maintenance/backup_PageTest.php M tests/phpunit/maintenance/fetchTextTest.php M tests/phpunit/maintenance/getSlaveServerTest.php M tests/phpunit/skins/SideBarTest.php 64 files changed, 198 insertions(+), 252 deletions(-) Approvals: Siebrand: Looks good to me, approved Hashar: Looks good to me, but someone else must approve Umherirrender: Looks good to me, but someone else must approve jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/46225 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96aacef5bafe5a2bca659744fba1380999cfc37d Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Hashar <[email protected]> Gerrit-Reviewer: Hashar <[email protected]> Gerrit-Reviewer: Siebrand <[email protected]> Gerrit-Reviewer: Umherirrender <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
