Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/300849
Change subject: mediawiki.special.userlogin.signup: Remove unnecessary field
hiding code
......................................................................
mediawiki.special.userlogin.signup: Remove unnecessary field hiding code
We now use HTMLForm, which implements a generic methods to do this
using 'hide-if' parameters. We already use it for the signup form too.
This is just dead code.
Change-Id: I35cfc31aae714f3be8aa0d044de1119c279e3d34
---
M resources/src/mediawiki.special/mediawiki.special.userlogin.signup.js
1 file changed, 0 insertions(+), 28 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/49/300849/1
diff --git
a/resources/src/mediawiki.special/mediawiki.special.userlogin.signup.js
b/resources/src/mediawiki.special/mediawiki.special.userlogin.signup.js
index 24f54d0..770a2f0 100644
--- a/resources/src/mediawiki.special/mediawiki.special.userlogin.signup.js
+++ b/resources/src/mediawiki.special/mediawiki.special.userlogin.signup.js
@@ -2,34 +2,6 @@
* JavaScript for signup form.
*/
( function ( mw, $ ) {
- // When sending password by email, hide the password input fields.
- $( function () {
- // Always required if checked, otherwise it depends, so we use
the original
- var $emailLabel = $( 'label[for="wpEmail"]' ),
- originalText = $emailLabel.text(),
- requiredText = mw.message( 'createacct-emailrequired'
).text(),
- $createByMailCheckbox = $( '#wpCreateaccountMail' ),
- $beforePwds = $( '.mw-row-password:first' ).prev(),
- $pwds;
-
- function updateForCheckbox() {
- var checked = $createByMailCheckbox.prop( 'checked' );
- if ( checked ) {
- $pwds = $( '.mw-row-password' ).detach();
- $emailLabel.text( requiredText );
- } else {
- if ( $pwds ) {
- $beforePwds.after( $pwds );
- $pwds = null;
- }
- $emailLabel.text( originalText );
- }
- }
-
- $createByMailCheckbox.on( 'change', updateForCheckbox );
- updateForCheckbox();
- } );
-
// Check if the username is invalid or already taken
$( function () {
var
--
To view, visit https://gerrit.wikimedia.org/r/300849
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I35cfc31aae714f3be8aa0d044de1119c279e3d34
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
