Robert Vogel has submitted this change and it was merged.

Change subject: BsAboutBlueSpice: Using the new BsExtensionManager and an 
extension.json
......................................................................


BsAboutBlueSpice: Using the new BsExtensionManager and an extension.json

=> Requires I70b44bffc2b696e43140a570c98cb5431c38ff20

PatchSet2:
* Added 'name' property
* Added bsgBSExtensions property

PatchSet3:
* Converted EXTINFO into extension.json
* Removed constructor completely

Change-Id: I74a8cd44e688c237d4f9ad856c4b429d033334fb
---
M AboutBlueSpice/AboutBlueSpice.class.php
M AboutBlueSpice/AboutBlueSpice.setup.php
A AboutBlueSpice/extension.json
3 files changed, 41 insertions(+), 40 deletions(-)

Approvals:
  Robert Vogel: Verified; Looks good to me, approved
  jenkins-bot: Checked



diff --git a/AboutBlueSpice/AboutBlueSpice.class.php 
b/AboutBlueSpice/AboutBlueSpice.class.php
index 0c4a449..4869298 100644
--- a/AboutBlueSpice/AboutBlueSpice.class.php
+++ b/AboutBlueSpice/AboutBlueSpice.class.php
@@ -33,26 +33,6 @@
 
 class AboutBlueSpice extends BsExtensionMW {
 
-       public function __construct() {
-               wfProfileIn( 'BS::'.__METHOD__ );
-
-               // Base settings
-               $this->mExtensionFile = __FILE__;
-               $this->mExtensionType = EXTTYPE::VARIABLE;
-               $this->mInfo = array(
-                       EXTINFO::NAME => 'AboutBlueSpice',
-                       EXTINFO::DESCRIPTION => 'bs-aboutbluespice-desc',
-                       EXTINFO::AUTHOR      => 'Markus Glaser',
-                       EXTINFO::VERSION     => 'default',
-                       EXTINFO::STATUS      => 'default',
-                       EXTINFO::PACKAGE     => 'default',
-                       EXTINFO::URL => 
'https://help.bluespice.com/index.php/AboutBlueSpice',
-                       EXTINFO::DEPS => array ( 'bluespice' => '2.23.1' )
-               );
-               $this->mExtensionKey = 'MW::AboutBluespice';
-               wfProfileOut( 'BS::'.__METHOD__ );
-       }
-
        protected function initExt() {
                wfProfileIn( 'BS::'.__METHOD__ );
                // Hooks
diff --git a/AboutBlueSpice/AboutBlueSpice.setup.php 
b/AboutBlueSpice/AboutBlueSpice.setup.php
index 26ac218..3465638 100644
--- a/AboutBlueSpice/AboutBlueSpice.setup.php
+++ b/AboutBlueSpice/AboutBlueSpice.setup.php
@@ -1,23 +1,4 @@
 <?php
 
-BsExtensionManager::registerExtension( 'AboutBlueSpice', BsRUNLEVEL::FULL | 
BsRUNLEVEL::REMOTE );
+wfLoadExtension( 'BlueSpiceExtensions/AboutBlueSpice' );
 
-$wgAutoloadClasses['AboutBlueSpice'] = __DIR__ . '/AboutBlueSpice.class.php';
-$wgAutoloadClasses['SpecialAboutBlueSpice'] = __DIR__ . 
'/includes/specials/SpecialAboutBlueSpice.class.php';
-
-$wgMessagesDirs['AboutBlueSpice'] = __DIR__ . '/i18n';
-
-$wgSpecialPages['AboutBlueSpice'] = 'SpecialAboutBlueSpice';
-$wgExtensionMessagesFiles['AboutBlueSpiceAlias'] = __DIR__ . 
'/includes/specials/SpecialAboutBlueSpice.alias.php';
-
-$aResourceModuleTemplate = array (
-       'localBasePath' => __DIR__ . '/resources',
-       'remoteExtPath' => 'BlueSpiceExtensions/AboutBlueSpice/resources'
-);
-
-$wgResourceModules['ext.bluespice.aboutbluespice'] = array (
-       'styles' => 'bluespice.aboutbluespice.css',
-       'position' => 'top'
-) + $aResourceModuleTemplate;
-
-unset( $aResoureModuleTemplate );
diff --git a/AboutBlueSpice/extension.json b/AboutBlueSpice/extension.json
new file mode 100644
index 0000000..4cf3790
--- /dev/null
+++ b/AboutBlueSpice/extension.json
@@ -0,0 +1,40 @@
+{
+       "name": "AboutBlueSpice",
+       "version": "2.27.0",
+       "url": "https://help.bluespice.com/index.php/AboutBlueSpice";,
+       "author": "Markus Glaser",
+       "descriptionmsg": "bs-aboutbluespice-desc",
+       "type": "bluespice",
+       "SpecialPages": {
+               "AboutBlueSpice": "SpecialAboutBlueSpice"
+       },
+       "MessagesDirs": {
+               "AboutBlueSpice": [
+                       "i18n"
+               ]
+       },
+       "ExtensionMessagesFiles": {
+               "AboutBlueSpiceAlias": 
"includes/specials/SpecialAboutBlueSpice.alias.php"
+       },
+       "AutoloadClasses": {
+               "AboutBlueSpice": "AboutBlueSpice.class.php",
+               "SpecialAboutBlueSpice": 
"includes/specials/SpecialAboutBlueSpice.class.php"
+       },
+       "ResourceModules": {
+               "ext.bluespice.aboutbluespice": {
+                       "styles": "bluespice.aboutbluespice.css",
+                       "position": "top"
+               }
+       },
+       "ResourceFileModulePaths": {
+               "localBasePath": "resources",
+               "remoteExtPath": "BlueSpiceExtensions/AboutBlueSpice/resources"
+       },
+       "bsgBSExtensions": {
+               "AboutBlueSpice": {
+                       "className": "AboutBlueSpice",
+                       "extPath": "/BlueSpiceExtensions/AboutBlueSpice"
+               }
+       },
+       "manifest_version": 1
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/299173
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I74a8cd44e688c237d4f9ad856c4b429d033334fb
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: master
Gerrit-Owner: Pwirth <[email protected]>
Gerrit-Reviewer: Dvogel hallowelt <[email protected]>
Gerrit-Reviewer: Ljonka <[email protected]>
Gerrit-Reviewer: Mglaser <[email protected]>
Gerrit-Reviewer: Robert Vogel <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to