Tobias Gritschacher has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/300885

Change subject: Avoid logging in when not necessary
......................................................................

Avoid logging in when not necessary

Change-Id: Iaa673a7051fe5c97b5cf42f92ad9bdcc69067cd3
---
M tests/browser/features/step_definitions/entity_steps.rb
M tests/browser/features/support/pages/item_page.rb
2 files changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikidata/browsertests 
refs/changes/85/300885/1

diff --git a/tests/browser/features/step_definitions/entity_steps.rb 
b/tests/browser/features/step_definitions/entity_steps.rb
index aca9451..b03fbce 100644
--- a/tests/browser/features/step_definitions/entity_steps.rb
+++ b/tests/browser/features/step_definitions/entity_steps.rb
@@ -99,7 +99,6 @@
 
 Given(/^The following sitelinks do not exist:$/) do |sitelinks|
   wb_api = MediawikiApi::Wikidata::WikidataClient.new URL.repo_api
-  wb_api.log_in(ENV['MEDIAWIKI_USER'], ENV['MEDIAWIKI_PASSWORD'])
   sitelinks.raw.each do |sitelink|
     if wb_api.sitelink_exists?(sitelink[0], sitelink[1])
       wb_api.remove_sitelink({ site_id: sitelink[0], title: sitelink[1] }, 
sitelink[0])
diff --git a/tests/browser/features/support/pages/item_page.rb 
b/tests/browser/features/support/pages/item_page.rb
index 528735d..4dc63e2 100644
--- a/tests/browser/features/support/pages/item_page.rb
+++ b/tests/browser/features/support/pages/item_page.rb
@@ -26,7 +26,6 @@
 
   def create_item(data)
     wb_api = MediawikiApi::Wikidata::WikidataClient.new URL.repo_api
-    wb_api.log_in(ENV['MEDIAWIKI_USER'], ENV['MEDIAWIKI_PASSWORD'])
     resp = wb_api.create_item(data)
 
     id = resp['entity']['id']

-- 
To view, visit https://gerrit.wikimedia.org/r/300885
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa673a7051fe5c97b5cf42f92ad9bdcc69067cd3
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/browsertests
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to