jenkins-bot has submitted this change and it was merged.
Change subject: Prevent undeleting entities from ending with an exception
......................................................................
Prevent undeleting entities from ending with an exception
Bug: T140533
Change-Id: I4b256879e212dce01efd1def662cab8dcb97b4e7
(cherry picked from commit a5b635a9603b4649a2e4e8f66d3f6e54c8a6c189)
---
M repo/Wikibase.hooks.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Aude: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/Wikibase.hooks.php b/repo/Wikibase.hooks.php
index 576be14..a9a9690 100644
--- a/repo/Wikibase.hooks.php
+++ b/repo/Wikibase.hooks.php
@@ -458,7 +458,7 @@
:
$skinTemplate->getRevisionId();
$rev = Revision::newFromId( $revid );
- if ( $rev->isDeleted(
Revision::DELETED_TEXT ) ) {
+ if ( !$rev || $rev->isDeleted(
Revision::DELETED_TEXT ) ) {
return;
}
--
To view, visit https://gerrit.wikimedia.org/r/300749
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b256879e212dce01efd1def662cab8dcb97b4e7
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: wmf/1.28.0-wmf.9
Gerrit-Owner: Aude <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Matěj Suchánek <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
