jenkins-bot has submitted this change and it was merged.
Change subject: Add null check for $title in MediaInfoView
......................................................................
Add null check for $title in MediaInfoView
Bug: T141322
Change-Id: I8e0151f0d9dd598e184cfec67d2d6cac6c1628be
---
M src/View/MediaInfoView.php
1 file changed, 8 insertions(+), 4 deletions(-)
Approvals:
Jonas Kress (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/View/MediaInfoView.php b/src/View/MediaInfoView.php
index 2aa6034..9be74c9 100644
--- a/src/View/MediaInfoView.php
+++ b/src/View/MediaInfoView.php
@@ -105,12 +105,16 @@
* @return string HTML
*/
private function getFileLinkHtml( MediaInfoId $id = null ) {
- if ( !$id ) {
- return '';
+ $html = '';
+
+ if ( $id ) {
+ $title = $this->filePageLookup->getFilePage( $id );
+
+ if ( $title ) {
+ $html = $this->linkRenderer->makeKnownLink(
$title );
+ }
}
- $title = $this->filePageLookup->getFilePage( $id );
- $html = $this->linkRenderer->makeKnownLink( $title );
return $html;
}
--
To view, visit https://gerrit.wikimedia.org/r/301024
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e0151f0d9dd598e184cfec67d2d6cac6c1628be
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseMediaInfo
Gerrit-Branch: master
Gerrit-Owner: Aude <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
