Giuseppe Lavagetto has submitted this change and it was merged.
Change subject: kafka_config: sort arrays as well
......................................................................
kafka_config: sort arrays as well
Bug: T141242
Change-Id: I8aaa80f5596bf6b9c3fc6fe2534024e3ee296ab1
---
M modules/role/lib/puppet/parser/functions/kafka_config.rb
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Giuseppe Lavagetto: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/role/lib/puppet/parser/functions/kafka_config.rb
b/modules/role/lib/puppet/parser/functions/kafka_config.rb
index 5e1f487..3905d1f 100644
--- a/modules/role/lib/puppet/parser/functions/kafka_config.rb
+++ b/modules/role/lib/puppet/parser/functions/kafka_config.rb
@@ -61,11 +61,11 @@
'name' => cluster_name,
'brokers' => {
'hash' => brokers,
- 'array' => brokers.keys,
+ 'array' => brokers.keys.sort,
# list of comma-separated host:port broker pairs
'string' => brokers.map { |host, conf| "#{host}:#{conf['port'] ||
9092}" }.sort.join(','),
# list of comma-separated host_9999 broker pairs used as graphite
wildcards
- 'graphite' => "{#{brokers.keys.map { |b| "#{b.tr '.',
'_'}_#{jmx_port}" }.join(',')}}",
+ 'graphite' => "{#{brokers.keys.map { |b| "#{b.tr '.',
'_'}_#{jmx_port}" }.sort.join(',')}}",
'size' => brokers.keys.size
},
'jmx_port' => jmx_port,
--
To view, visit https://gerrit.wikimedia.org/r/301070
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8aaa80f5596bf6b9c3fc6fe2534024e3ee296ab1
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Giuseppe Lavagetto <[email protected]>
Gerrit-Reviewer: Giuseppe Lavagetto <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
