jenkins-bot has submitted this change and it was merged.
Change subject: Remove unused method from entity_module
......................................................................
Remove unused method from entity_module
Change-Id: I80a306736bdbbb6c42e461ee85688362b0a9ea81
---
M tests/browser/features/support/modules/entity_module.rb
1 file changed, 0 insertions(+), 57 deletions(-)
Approvals:
WMDE-Fisch: Looks good to me, approved
Jonas Kress (WMDE): Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/tests/browser/features/support/modules/entity_module.rb
b/tests/browser/features/support/modules/entity_module.rb
index c2f71b5..6553c80 100644
--- a/tests/browser/features/support/modules/entity_module.rb
+++ b/tests/browser/features/support/modules/entity_module.rb
@@ -142,61 +142,4 @@
cookie = "$.cookie( 'wikibase-no-anonymouseditwarning', '1', { 'expires':
null, 'path': '/' } );"
execute_script(cookie)
end
-
- # this method was moved from wikibase_api_module.rb since we are now using
the mediawiki_api/wikidata gem for doing API requests
- # this method is really ugly and should be refactored
- def create_entity_and_properties(serialization)
- wb_api = MediawikiApi::Wikidata::WikidataClient.new URL.repo_api
- wb_api.log_in(ENV['MEDIAWIKI_USER'], ENV['MEDIAWIKI_PASSWORD'])
-
- serialization['properties'].each do |old_id, prop|
- if prop['description'] && prop['description']['en']['value']
- search = prop['description']['en']['value']
- else
- search = prop['labels']['en']['value']
- end
- resp = wb_api.search_entities(search, 'en', 'property')
- resp['search'].reject! do |found_prop|
- found_prop['label'] != prop['labels']['en']['value']
- end
- if resp['search'][0]
- id = resp['search'][0]['id']
- else
- saved_prop = wb_api.create_property(prop)
- id = saved_prop['id']
- end
-
- serialization['entity']['claims'].each do |claim|
- if claim['mainsnak']['property'] == old_id
- claim['mainsnak']['property'] = id
- end
- if claim['qualifiers']
- claim['qualifiers'].each do |qualifier|
- if qualifier['property'] == old_id
- qualifier['property'] = id
- end
- end
- end
- if claim['qualifiers-order']
- claim['qualifiers-order'].map! do |p_id|
- p_id == old_id ? id : p_id
- end
- end
- if claim['references']
- claim['references'].each do |reference|
- reference['snaks'].each do |snak|
- if snak['property'] == old_id
- snak['property'] = id
- end
- end
- reference['snaks-order'].map! do |p_id|
- p_id == old_id ? id : p_id
- end
- end
- end
- end
- end
-
- wb_api.create_item(serialization['entity'])
- end
end
--
To view, visit https://gerrit.wikimedia.org/r/300876
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I80a306736bdbbb6c42e461ee85688362b0a9ea81
Gerrit-PatchSet: 2
Gerrit-Project: wikidata/browsertests
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: WMDE-Fisch <[email protected]>
Gerrit-Reviewer: Zfilipin <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
