GWicke has uploaded a new change for review. https://gerrit.wikimedia.org/r/301309
Change subject: Service::node: Capture stdout and stderr in journal ...................................................................... Service::node: Capture stdout and stderr in journal Fatal errors frequently do not make it into regular service logs. During startup, other logging infrastructure might not be available yet, and sudden fatals don't necessarily leave time to actually send out logs before the process exits. Production services generally do not log to stdout / stderr (they use logstash or separate log files), so it should be safe to capture such output to the systemd journal by default. Bug: T136957 Change-Id: Ib038cb6bd9312c17875a60c476d846efd2f89c6f --- M modules/service/templates/initscripts/node.systemd.erb 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/09/301309/1 diff --git a/modules/service/templates/initscripts/node.systemd.erb b/modules/service/templates/initscripts/node.systemd.erb index f9de25e..fb98071 100644 --- a/modules/service/templates/initscripts/node.systemd.erb +++ b/modules/service/templates/initscripts/node.systemd.erb @@ -20,5 +20,10 @@ WorkingDirectory=/srv/deployment/<%= @repo %> ExecStart=/usr/bin/firejail --blacklist=/root --blacklist=/home --caps --seccomp /usr/bin/nodejs <%= @starter_script %> -c /etc/<%= @title %>/config.yaml +# Always redirect stdout and stderr to the journal. Production services only +# log fatal errors to stderr / stdout, and use logstash (or log files) for +# regular app logs. StandardError is piped to stdout by systemd's defaults. +StandardOutput=journal + [Install] WantedBy=multi-user.target -- To view, visit https://gerrit.wikimedia.org/r/301309 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib038cb6bd9312c17875a60c476d846efd2f89c6f Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: GWicke <gwi...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
