jenkins-bot has submitted this change and it was merged.
Change subject: Fix random test by tolerating less random randomness
......................................................................
Fix random test by tolerating less random randomness
randomTokenMatch() may randomly behave less random.
Follows-up 8b3cb1b. Should help avoid this false positive causing
MediaWiki core commits to fail Jenkins due to alleged breakage
in EventLogging extension.
> Chrome 51.0.2704 (Linux 0.0.0) randomTokenMatch FAILED
> True: 22
> False: 78
Change-Id: Ib6c8186e1d738a2ae6e4114a29f86199bbb81380
---
M tests/ext.eventLogging.tests.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Florianschmidtwelzow: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/ext.eventLogging.tests.js b/tests/ext.eventLogging.tests.js
index d156ff0..21eeb04 100644
--- a/tests/ext.eventLogging.tests.js
+++ b/tests/ext.eventLogging.tests.js
@@ -115,8 +115,8 @@
for ( i = 0; i < 100; i++ ) {
results[ mw.eventLog.randomTokenMatch( 10 ) ]++;
}
- assert.ok( results[ 'true' ] > 0 && results[ 'true' ] < 20,
'True: ' + results[ 'true' ] );
- assert.ok( results[ 'false' ] > 80 && results[ 'false' ] < 100,
'False: ' + results[ 'false' ] );
+ assert.ok( results[ 'true' ] > 0 && results[ 'true' ] < 25,
'True: ' + results[ 'true' ] );
+ assert.ok( results[ 'false' ] > 75 && results[ 'false' ] < 100,
'False: ' + results[ 'false' ] );
} );
QUnit.asyncTest( 'logEvent', 1, function ( assert ) {
--
To view, visit https://gerrit.wikimedia.org/r/301316
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6c8186e1d738a2ae6e4114a29f86199bbb81380
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org>
Gerrit-Reviewer: Reedy <re...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
