jenkins-bot has submitted this change and it was merged.

Change subject: legacyBtn can sometimes be null
......................................................................


legacyBtn can sometimes be null

This was introduced in I85db419.

Bug: T141571
Change-Id: I62f9ba3a6103a44df557730c946626af0b5a0fcc
---
M resources/skins.minerva.scripts/init.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Phuedx: Looks good to me, approved



diff --git a/resources/skins.minerva.scripts/init.js 
b/resources/skins.minerva.scripts/init.js
index fc693d8..8ba28c6 100644
--- a/resources/skins.minerva.scripts/init.js
+++ b/resources/skins.minerva.scripts/init.js
@@ -167,7 +167,7 @@
                        } );
 
                        // If both buttons are shown setup switch behaviour.
-                       if ( $legacyBtn.length && $primaryBtn.length ) {
+                       if ( ( $legacyBtn && $legacyBtn.length ) && 
$primaryBtn.length ) {
                                $legacyBtn.on( 'click', function ( ev ) {
                                        ev.preventDefault();
 

-- 
To view, visit https://gerrit.wikimedia.org/r/301705
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I62f9ba3a6103a44df557730c946626af0b5a0fcc
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Phuedx <g...@samsmith.io>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to