Ottomata has submitted this change and it was merged.

Change subject: Hieraize eventlogging_kafka_handler to allow selection of 
different kafka clients
......................................................................


Hieraize eventlogging_kafka_handler to allow selection of different kafka 
clients

This allows us to test things like the new confluent kafka python client
without affecting all eventlogging instances at once.

Bug: T141285 T116035
Change-Id: I983a22d7d98bbcbd72592d80d84a135451373a1d
---
M modules/role/manifests/eventbus/eventbus.pp
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Ottomata: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/role/manifests/eventbus/eventbus.pp 
b/modules/role/manifests/eventbus/eventbus.pp
index 53468ca..ec0c5aa 100644
--- a/modules/role/manifests/eventbus/eventbus.pp
+++ b/modules/role/manifests/eventbus/eventbus.pp
@@ -30,7 +30,12 @@
     }
 
     $kafka_brokers_array = $config['brokers']['array']
-    $kafka_base_uri      = inline_template('kafka:///<%= 
@kafka_brokers_array.join(":9092,") + ":9092" %>')
+
+    # We are trying out different kafka clients in eventlogging.
+    # The default Kafka handler 'protocol' is 'kafka://'.  Other
+    # handlers are named differently, e.g. 'confluent-kafka://'.
+    $eventlogging_kafka_handler = hiera('eventlogging_kafka_handler', 'kafka')
+    $kafka_base_uri      = inline_template('<%= @eventlogging_kafka_handler 
%>:///<%= @kafka_brokers_array.join(":9092,") + ":9092" %>')
 
     $outputs = [
         # When events are produced to kafka, the

-- 
To view, visit https://gerrit.wikimedia.org/r/301126
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I983a22d7d98bbcbd72592d80d84a135451373a1d
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ottomata <[email protected]>
Gerrit-Reviewer: Ottomata <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to