jenkins-bot has submitted this change and it was merged. Change subject: Added support for passing data into annotation constructors ......................................................................
Added support for passing data into annotation constructors This resolves a TODO * Added logic to support passing an argument into annotation constructor which is used as the data property (reusing the element argument) * Updated documentation * Simplified instantiation of annotations Change-Id: I142b8fa3883bf70c896a2a568088d833814ef2dc --- M modules/ve/dm/annotations/ve.dm.LinkAnnotation.js M modules/ve/dm/annotations/ve.dm.MWExternalLinkAnnotation.js M modules/ve/dm/annotations/ve.dm.MWInternalLinkAnnotation.js M modules/ve/dm/annotations/ve.dm.TextStyleAnnotation.js M modules/ve/dm/ve.dm.Annotation.js M modules/ve/dm/ve.dm.SurfaceFragment.js M modules/ve/ui/inspectors/ve.ui.LinkInspector.js M modules/ve/ui/inspectors/ve.ui.MWLinkInspector.js M modules/ve/ui/widgets/ve.ui.LinkTargetInputWidget.js M modules/ve/ui/widgets/ve.ui.MWLinkTargetInputWidget.js 10 files changed, 30 insertions(+), 46 deletions(-) Approvals: Catrope: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/45280 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I142b8fa3883bf70c896a2a568088d833814ef2dc Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Trevor Parscal <[email protected]> Gerrit-Reviewer: Catrope <[email protected]> Gerrit-Reviewer: Krinkle <[email protected]> Gerrit-Reviewer: Trevor Parscal <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
