jenkins-bot has submitted this change and it was merged. Change subject: Move tests to tests/phpunit for autodiscovery ......................................................................
Move tests to tests/phpunit for autodiscovery And remove no-longer needed UnitTestsList hook subscriber. See <https://www.mediawiki.org/wiki/Manual:PHP_unit_testing/Writing_unit_tests_for_extensions#Register_your_tests> Change-Id: Ib9f2f305402b29b2f56f7ae3ba51523a26c33f5d --- M CodeReviewHooks.php M extension.json R tests/phpunit/CodeReviewApiTest.php R tests/phpunit/CodeReviewTest.php R tests/phpunit/DiffHighlighterTest.php 5 files changed, 0 insertions(+), 16 deletions(-) Approvals: Reedy: Looks good to me, approved jenkins-bot: Verified diff --git a/CodeReviewHooks.php b/CodeReviewHooks.php index 4557042..390e709 100644 --- a/CodeReviewHooks.php +++ b/CodeReviewHooks.php @@ -163,17 +163,4 @@ } return true; } - - /** - * Register PHP unit tests. - * - * @param $files array - * @return bool - */ - public static function onUnitTestsList( &$files ) { - $files[] = __DIR__ . '/tests/CodeReviewApiTest.php'; - $files[] = __DIR__ . '/tests/CodeReviewTest.php'; - $files[] = __DIR__ . '/tests/DiffHighlighterTest.php'; - return true; - } } diff --git a/extension.json b/extension.json index a88d20a..f6bc8d1 100644 --- a/extension.json +++ b/extension.json @@ -79,9 +79,6 @@ ], "UserMergeAccountFields": [ "CodeReviewHooks::onUserMergeAccountFields" - ], - "UnitTestsList": [ - "CodeReviewHooks::onUnitTestsList" ] }, "MessagesDirs": { diff --git a/tests/CodeReviewApiTest.php b/tests/phpunit/CodeReviewApiTest.php similarity index 100% rename from tests/CodeReviewApiTest.php rename to tests/phpunit/CodeReviewApiTest.php diff --git a/tests/CodeReviewTest.php b/tests/phpunit/CodeReviewTest.php similarity index 100% rename from tests/CodeReviewTest.php rename to tests/phpunit/CodeReviewTest.php diff --git a/tests/DiffHighlighterTest.php b/tests/phpunit/DiffHighlighterTest.php similarity index 100% rename from tests/DiffHighlighterTest.php rename to tests/phpunit/DiffHighlighterTest.php -- To view, visit https://gerrit.wikimedia.org/r/302958 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9f2f305402b29b2f56f7ae3ba51523a26c33f5d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CodeReview Gerrit-Branch: master Gerrit-Owner: Legoktm <[email protected]> Gerrit-Reviewer: Jack Phoenix <[email protected]> Gerrit-Reviewer: Legoktm <[email protected]> Gerrit-Reviewer: Reedy <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
