jenkins-bot has submitted this change and it was merged.

Change subject: Hack around browser bug in IE breaking badge alignment in 
Monobook
......................................................................


Hack around browser bug in IE breaking badge alignment in Monobook

A browser bug causes the badges to be pushed down by 1em in IE11
and below, but not in Edge. The only way I could find to work
around this was to add top:-1em; in IE browsers using CSS hacks.

Bug: T142053
Change-Id: If240f7281dd795085c003af524da294d5bf5ff76
---
M modules/nojs/mw.echo.badge.monobook.less
1 file changed, 13 insertions(+), 0 deletions(-)

Approvals:
  Krinkle: Looks good to me, but someone else must approve
  Mooeypoo: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/nojs/mw.echo.badge.monobook.less 
b/modules/nojs/mw.echo.badge.monobook.less
index f1aafb5..ab5e3ef 100644
--- a/modules/nojs/mw.echo.badge.monobook.less
+++ b/modules/nojs/mw.echo.badge.monobook.less
@@ -49,4 +49,17 @@
 #p-personal #pt-notifications-alert,
 #p-personal #pt-notifications-notice {
        display: inline-block;
+       position: relative;
+
+       // HACK for IE6-9 (T142053)
+       top: ~"-1em\9";
+}
+
+
+// HACK for IE10 and IE11 (T142053)
+@media all and (-ms-high-contrast: none), (-ms-high-contrast: active) {
+       #p-personal #pt-notifications-alert,
+       #p-personal #pt-notifications-notice {
+               top: -1em;
+       }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/302854
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If240f7281dd795085c003af524da294d5bf5ff76
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Mooeypoo <mor...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to