Hoo man has uploaded a new change for review. https://gerrit.wikimedia.org/r/303556
Change subject: Use a buffering term lookup for mw.wikibase.label ...................................................................... Use a buffering term lookup for mw.wikibase.label Instead of an EntityRetrievingTermLookup. I've benchmarked this in production with the wikitext given at https://de.wikipedia.org/wiki/Portal_Diskussion:Film/Kinostarts#Die_zum_Ausf.C3.BChren_von_Skripten_vorgesehene_Zeit_ist_abgelaufen. and not using EntityRetrievingTermLookup reduced the Lua run time for that by about 55%. Change-Id: I58d2e846a64705d320e57fa41694f6f75e57f3fa --- M client/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibrary.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/56/303556/1 diff --git a/client/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibrary.php b/client/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibrary.php index 6b1a57d..2ecd3f2 100644 --- a/client/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibrary.php +++ b/client/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibrary.php @@ -251,7 +251,7 @@ $labelDescriptionLookup = new LanguageFallbackLabelDescriptionLookup( new UsageTrackingTermLookup( - new EntityRetrievingTermLookup( $entityLookup ), + $wikibaseClient->getTermLookup(), $usageAccumulator ), $this->getLanguageFallbackChain() -- To view, visit https://gerrit.wikimedia.org/r/303556 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I58d2e846a64705d320e57fa41694f6f75e57f3fa Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Hoo man <h...@online.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
