Daniel Werner has submitted this change and it was merged. Change subject: (bug 42997, bug 44291) Handle invalid values in statements ui ......................................................................
(bug 42997, bug 44291) Handle invalid values in statements ui Depends on change I26cbd7e4 and change I460cfc67 in DataValues extension. Saving will not be possible anymore while the snak is invalid. - patch set 2: Rebase - patch set 3: Adapted change set to recent changes on master branch Change-Id: I4515a30093e18eb66d5938e50d91927306067069 --- M lib/resources/jquery.valueview.views/wikibaseItem.js M lib/resources/jquery.wikibase/jquery.wikibase.claimlistview.js M lib/resources/jquery.wikibase/jquery.wikibase.claimview.js M lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.ViewState.js M lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js M lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Value.js M lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Variation.js M repo/tests/selenium/statements/statements_spec.rb 8 files changed, 165 insertions(+), 30 deletions(-) Approvals: Daniel Werner: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/46525 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4515a30093e18eb66d5938e50d91927306067069 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Henning Snater <[email protected]> Gerrit-Reviewer: Daniel Werner <[email protected]> Gerrit-Reviewer: Henning Snater <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
