jenkins-bot has submitted this change and it was merged. Change subject: (bug 42198) fix ext.wikiEditor.publish so that it actually works ......................................................................
(bug 42198) fix ext.wikiEditor.publish so that it actually works Two fixes: * The Cancel button previously simply did nothing. However, since it's a button, it caused the form to be submitted - essentially saving the edit instead of cancelling it. Now it sets window's location to "Cancel" link's href (already present in vanilla MediaWiki) and cancels the submitting of the edit form. * The Publish button did nothing as well (except that it cancelled the form submission). This was caused by the dialog it was supposed to show not being initialized. I simply forced its initialization using "immediateCreate: true". Change-Id: I64589985b6075183e66eaa40bc457acbbae380b1 --- M modules/jquery.wikiEditor.publish.js 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Matthias Mullie: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/44989 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64589985b6075183e66eaa40bc457acbbae380b1 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/WikiEditor Gerrit-Branch: master Gerrit-Owner: Matmarex <[email protected]> Gerrit-Reviewer: Krinkle <[email protected]> Gerrit-Reviewer: Matmarex <[email protected]> Gerrit-Reviewer: Matthias Mullie <[email protected]> Gerrit-Reviewer: Trevor Parscal <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
