Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/303994
Change subject: Whitespace fix-ups
......................................................................
Whitespace fix-ups
Change-Id: Ib2fac25d997131b0ca7cdf2a79972c85798fbe72
---
M embed.html
M robots.txt
M wikibase/queryService/api/QuerySamples.js
M wikibase/queryService/ui/App.js
M wikibase/queryService/ui/QueryExampleDialog.js
M wikibase/queryService/ui/editor/Editor.js
M wikibase/queryService/ui/resultBrowser/BubbleChartResultBrowser.js
M wikibase/queryService/ui/resultBrowser/CoordinateResultBrowser.js
M wikibase/queryService/ui/resultBrowser/GraphResultBrowser.js
M wikibase/queryService/ui/resultBrowser/ImageResultBrowser.js
M wikibase/queryService/ui/resultBrowser/MultiDimensionResultBrowser.js
M wikibase/queryService/ui/resultBrowser/TableResultBrowser.js
M wikibase/queryService/ui/resultBrowser/TimelineResultBrowser.js
M wikibase/queryService/ui/resultBrowser/TreeMapResultBrowser.js
M wikibase/queryService/ui/resultBrowser/helper/FormatterHelper.js
M wikibase/queryService/ui/visualEditor/SelectorBox.js
M wikibase/queryService/ui/visualEditor/SparqlQuery.js
M wikibase/queryService/ui/visualEditor/VisualEditor.js
M wikibase/tests/queryService/ui/editor/hint/Rdf.test.js
M wikibase/tests/queryService/ui/resultBrowser/ResultBrowser.test.js
M wikibase/tests/queryService/ui/visualEditor/SparqlQuery.test.js
M wikibase/tests/queryService/ui/visualEditor/VisualEditor.test.js
22 files changed, 36 insertions(+), 87 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/gui
refs/changes/94/303994/1
diff --git a/embed.html b/embed.html
index 23d9e18..1fe1056 100644
--- a/embed.html
+++ b/embed.html
@@ -123,7 +123,6 @@
browser.setResult(
api.getResultRawData() );
browser.draw( $( '#result' ) );
$( '#progress' ).hide();
-
} catch ( e ) {
$( '#progress' ).hide();
$( '#error' ).show();
@@ -132,7 +131,6 @@
$( '#progress' ).hide();
$( '#error' ).show();
} );
-
} );
</script>
</body>
diff --git a/robots.txt b/robots.txt
index 0af05cf..641283d 100644
--- a/robots.txt
+++ b/robots.txt
@@ -2,4 +2,3 @@
User-agent: *
Disallow: /sparql
Disallow: /bigdata
-
diff --git a/wikibase/queryService/api/QuerySamples.js
b/wikibase/queryService/api/QuerySamples.js
index db8f0fb..aca3a40 100644
--- a/wikibase/queryService/api/QuerySamples.js
+++ b/wikibase/queryService/api/QuerySamples.js
@@ -26,7 +26,6 @@
* @return {jQuery.Promise} Object taking list of example queries {
title:, query: }
*/
SELF.prototype.getExamples = function () {
-
var deferred = $.Deferred(),
self = this;
diff --git a/wikibase/queryService/ui/App.js b/wikibase/queryService/ui/App.js
index b20e3c5..b47b72b 100644
--- a/wikibase/queryService/ui/App.js
+++ b/wikibase/queryService/ui/App.js
@@ -27,7 +27,6 @@
* @param {wikibase.queryService.api.Sparql} visualEditor
*/
function SELF( $element, editor, visualEditor, sparqlApi,
querySamplesApi ) {
-
this._$element = $element;
this._editor = editor;
this._visualEditor = visualEditor;
@@ -154,7 +153,6 @@
* @private
*/
SELF.prototype._init = function() {
-
if ( !this._sparqlApi ) {
this._sparqlApi = new
wikibase.queryService.api.Sparql();
}
@@ -497,7 +495,6 @@
};
var downloadHandler = function( filename, handler, mimetype ) {
-
return function( e ) {
e.preventDefault();
@@ -523,7 +520,6 @@
* @private
*/
SELF.prototype._initResultBrowserMenu = function() {
-
$.each( this._resultBrowsers, function( key, b ) {
var $element = $( '<li><a class="result-browser"
href="#">' +
'<span class="glyphicon glyphicon-' +
b.icon + '"></span>' + b.label +
@@ -531,7 +527,6 @@
$element.appendTo( $( '#result-browser-menu' ) );
b.$element = $element;
} );
-
};
/**
@@ -677,8 +672,8 @@
self._actionBar.show(
'wdqs-action-error-display', 'warning' );
window.console.log( e.stack );
}
- self._handleQueryResultBrowsers();
+ self._handleQueryResultBrowsers();
}, 20 );
};
/**
@@ -716,7 +711,6 @@
window.location.hash = hash;
}
}
-
};
return SELF;
diff --git a/wikibase/queryService/ui/QueryExampleDialog.js
b/wikibase/queryService/ui/QueryExampleDialog.js
index 04f1647..6fc2166 100644
--- a/wikibase/queryService/ui/QueryExampleDialog.js
+++ b/wikibase/queryService/ui/QueryExampleDialog.js
@@ -80,7 +80,6 @@
self._drawTagCloud( true );
}
} );
-
};
/**
@@ -95,7 +94,6 @@
self._initTagCloud();
$.each( examples, function( key, example ) {
-
if ( example.category !== category ) {
category = example.category;
self._$element.find( '.searchable'
).append( $( '<tr>' ).addClass( 'active' )
@@ -103,7 +101,6 @@
}
self._addExample( example.title, example.query,
example.href, example.tags );
} );
-
} );
};
@@ -118,9 +115,7 @@
self._drawTagCloud();
clearInterval( interval );
}
-
}, 300 );
-
};
/**
@@ -157,7 +152,6 @@
delayedMode: true,
autoResize: true
} );
-
};
/**
@@ -289,7 +283,6 @@
$matchingElements.show();
$matchingElements.each( function( i, el ) {
$( el ).prevAll( 'tr.active' ).first().show();
-
} );
};
diff --git a/wikibase/queryService/ui/editor/Editor.js
b/wikibase/queryService/ui/editor/Editor.js
index 0282912..59be04b 100644
--- a/wikibase/queryService/ui/editor/Editor.js
+++ b/wikibase/queryService/ui/editor/Editor.js
@@ -135,7 +135,6 @@
hint.to = CodeMirror.Pos( hint.to.line,
hint.to.char );
deferred.resolve( hint );
-
} ).fail(
function() {// if rdf hint is rejected try
sparql hint
self._sparqlHint.getHint(
editorContent, lineContent, lineNum, cursorPos )
@@ -245,7 +244,6 @@
if ( localStorage ) {
localStorage.setItem( LOCAL_STORAGE_KEY, value );
}
-
};
/**
diff --git a/wikibase/queryService/ui/resultBrowser/BubbleChartResultBrowser.js
b/wikibase/queryService/ui/resultBrowser/BubbleChartResultBrowser.js
index 3892988..88ebb6b 100644
--- a/wikibase/queryService/ui/resultBrowser/BubbleChartResultBrowser.js
+++ b/wikibase/queryService/ui/resultBrowser/BubbleChartResultBrowser.js
@@ -68,7 +68,6 @@
data.children.push( item );
}
}
-
} );
var $wrapper = $( '<center>' );
@@ -142,7 +141,6 @@
return SELF.prototype._calculateLuma( d.color )
<= 0.5 ? '#FFF' : '#000';
}
} ).style( 'cursor', 'pointer' );
-
};
/**
@@ -173,7 +171,6 @@
* Check if this value contains an coordinate value.
*/
SELF.prototype._checkColumn = function( value ) {
-
if ( this._getFormatter().isNumber( value ) ) {
this._hasNumber = true;
}
diff --git a/wikibase/queryService/ui/resultBrowser/CoordinateResultBrowser.js
b/wikibase/queryService/ui/resultBrowser/CoordinateResultBrowser.js
index 8a5f6a0..404a28d 100644
--- a/wikibase/queryService/ui/resultBrowser/CoordinateResultBrowser.js
+++ b/wikibase/queryService/ui/resultBrowser/CoordinateResultBrowser.js
@@ -62,9 +62,7 @@
$element.html( container );
var markerGroup = this._getMarkerGroup(), map = L.map( 'map', {
- center: [
- 0, 0
- ],
+ center: [ 0, 0 ],
maxZoom: 18,
minZoom: 2,
fullscreenControl: true
@@ -138,8 +136,8 @@
* @private
*/
SELF.prototype._extractLongLat = function( point ) {
-
var globe = this._extractGlobe( point );
+
if ( globe !== null && globe !== GLOBE_EARTH ) {
return null;
}
diff --git a/wikibase/queryService/ui/resultBrowser/GraphResultBrowser.js
b/wikibase/queryService/ui/resultBrowser/GraphResultBrowser.js
index e8ce7ed..52872fb 100644
--- a/wikibase/queryService/ui/resultBrowser/GraphResultBrowser.js
+++ b/wikibase/queryService/ui/resultBrowser/GraphResultBrowser.js
@@ -76,7 +76,6 @@
}
}
} );
-
}
$( '<a class="btn btn-default">' ).click( function() {
@@ -106,7 +105,11 @@
* @private
*/
SELF.prototype._getData = function() {
- var nodes = {}, edges = {}, rows = [], format =
this._getFormatter(), node = {};
+ var nodes = {},
+ edges = {},
+ rows = [],
+ format = this._getFormatter(),
+ node = {};
this._iterateResult( function( field, key, row, rowIndex ) {
if ( !field || !field.value ) {
@@ -145,7 +148,6 @@
node.title += ' value:' + field.value;
node.shape = 'dot';
}
-
} );
var result = {
diff --git a/wikibase/queryService/ui/resultBrowser/ImageResultBrowser.js
b/wikibase/queryService/ui/resultBrowser/ImageResultBrowser.js
index 15ae4b1..d3a9ecb 100644
--- a/wikibase/queryService/ui/resultBrowser/ImageResultBrowser.js
+++ b/wikibase/queryService/ui/resultBrowser/ImageResultBrowser.js
@@ -35,7 +35,6 @@
this._grid = $( '<div class="masonry">' );
this._iterateResult( function( field, key, row ) {
-
if ( field && self._isCommonsResource( field.value ) ) {
var url = field.value, fileName =
self._getFormatter().getCommonsResourceFileName(
url );
@@ -43,7 +42,6 @@
self._grid.append( self._getItem(
self._getThumbnail( url ), self._getThumbnail(
url, 1000 ), fileName, row ) );
}
-
} );
$element.html( this._grid );
diff --git
a/wikibase/queryService/ui/resultBrowser/MultiDimensionResultBrowser.js
b/wikibase/queryService/ui/resultBrowser/MultiDimensionResultBrowser.js
index 528bce9..e3f206a 100644
--- a/wikibase/queryService/ui/resultBrowser/MultiDimensionResultBrowser.js
+++ b/wikibase/queryService/ui/resultBrowser/MultiDimensionResultBrowser.js
@@ -29,11 +29,11 @@
* @param {jQuery} $element to draw at
*/
SELF.prototype.draw = function( $element ) {
+ var dimensions = {},
+ data = [],
+ f = this._getFormatter();
- var dimensions = {}, data = [];
- var f = this._getFormatter();
this._iterateResult( function( field, key, row, rowNum ) {
-
if ( !data[rowNum] ) {
data[rowNum] = {};
}
@@ -51,15 +51,12 @@
};
if ( f.isNumber( field ) ) {
d.type = 'NUMBER';
-
}
if ( field && field.type === TIME_DATATYPE ) {
d.type = 'DATE';
-
}
dimensions[key] = d;
}
-
} );
this._draw( $element, data, _.values( dimensions ) );
@@ -87,9 +84,7 @@
within: function( d, extent ) {
return extent[0] <= d && d <= extent[1];
},
- defaultScale: d3.scale.linear().range( [
- height, 0
- ] )
+ defaultScale: d3.scale.linear().range( [
height, 0 ] )
},
'STRING': {
key: 'String',
@@ -100,9 +95,7 @@
within: function( d, extent, dim ) {
return extent[0] <= dim.scale( d ) &&
dim.scale( d ) <= extent[1];
},
- defaultScale: d3.scale.ordinal().rangePoints( [
- 0, height
- ] )
+ defaultScale: d3.scale.ordinal().rangePoints( [
0, height ] )
},
'DATE': {
key: 'Date',
@@ -113,9 +106,7 @@
within: function( d, extent ) {
return extent[0] <= d && d <= extent[1];
},
- defaultScale: d3.time.scale().range( [
- 0, height
- ] )
+ defaultScale: d3.time.scale().range( [ 0,
height ] )
}
};
@@ -125,9 +116,7 @@
var x = d3.scale.ordinal().domain( dimensions.map( function(
dim ) {
return dim.key;
- } ) ).rangePoints( [
- 0, width
- ] );
+ } ) ).rangePoints( [ 0, width ] );
var line = d3.svg.line().defined( function( d ) {
return !isNaN( d[1] );
diff --git a/wikibase/queryService/ui/resultBrowser/TableResultBrowser.js
b/wikibase/queryService/ui/resultBrowser/TableResultBrowser.js
index b74a299..96c3262 100644
--- a/wikibase/queryService/ui/resultBrowser/TableResultBrowser.js
+++ b/wikibase/queryService/ui/resultBrowser/TableResultBrowser.js
@@ -43,7 +43,6 @@
* @private
*/
SELF.prototype._sorter = {
-
string: function( val1, val2 ) {
return val1.localeCompare( val2 );
},
@@ -151,7 +150,6 @@
cookieExpire: '1y',
cookiesEnabled: [ 'bs.table.pageList' ]
} );
-
};
/**
diff --git a/wikibase/queryService/ui/resultBrowser/TimelineResultBrowser.js
b/wikibase/queryService/ui/resultBrowser/TimelineResultBrowser.js
index a705ab7..498ccc6 100644
--- a/wikibase/queryService/ui/resultBrowser/TimelineResultBrowser.js
+++ b/wikibase/queryService/ui/resultBrowser/TimelineResultBrowser.js
@@ -51,7 +51,6 @@
var self = this, item = {};
this._iterateResult( function( field, key, row, rowIndex ) {
-
if ( self._getFormatter().isDateTime( field ) ) {
if ( !items[rowIndex] ) {// create new
var startDate =
self._getFormatter().parseDate( field.value );
diff --git a/wikibase/queryService/ui/resultBrowser/TreeMapResultBrowser.js
b/wikibase/queryService/ui/resultBrowser/TreeMapResultBrowser.js
index 0ea208f..d485c86 100644
--- a/wikibase/queryService/ui/resultBrowser/TreeMapResultBrowser.js
+++ b/wikibase/queryService/ui/resultBrowser/TreeMapResultBrowser.js
@@ -34,12 +34,14 @@
* @param {jQuery} $element to draw at
**/
SELF.prototype.draw = function( $element ) {
- var self = this;
-
- var data = {}, layer = data, size = null, url = null, prevRow =
null;
+ var self = this,
+ data = {},
+ layer = data,
+ size = null,
+ url = null,
+ prevRow = null;
this._iterateResult( function( field, key, row ) {
-
if ( row !== prevRow ) {
if ( prevRow !== null ) {
layer.data = {
@@ -66,8 +68,8 @@
if ( field && field.value &&
self._getFormatter().isExploreUrl( field.value ) ) {
url = field.value;
}
-
} );
+
layer.data = {
size: size,
url: url
@@ -83,7 +85,9 @@
};
SELF.prototype._createTreeData = function( data ) {
- var self = this, nodes = [], node;
+ var self = this,
+ nodes = [],
+ node;
if ( data.data ) {
return nodes;
@@ -355,7 +359,6 @@
d3.event.stopPropagation();
}
}
-
};
/* jshint ignore:end */
@@ -386,7 +389,6 @@
* Check if this value contains an coordinate value.
*/
SELF.prototype._checkColumn = function( value, key ) {
-
if ( this._getFormatter().isLabel( value, key ) ) {
this._labelColumns[key] = true;
diff --git a/wikibase/queryService/ui/resultBrowser/helper/FormatterHelper.js
b/wikibase/queryService/ui/resultBrowser/helper/FormatterHelper.js
index fe3cccd..7bd0f38 100644
--- a/wikibase/queryService/ui/resultBrowser/helper/FormatterHelper.js
+++ b/wikibase/queryService/ui/resultBrowser/helper/FormatterHelper.js
@@ -85,7 +85,6 @@
$html.append( $link );
if ( this.isCommonsResource( value ) ) {
-
if ( embed ) {
$link.click(
this.handleCommonResourceItem );
$link.append(
@@ -97,9 +96,9 @@
decodeURIComponent(
this.getCommonsResourceFileName( value ) ) );
$html.prepend(
this.createGalleryButton( value, title ), ' ' );
}
-
} else {
$link.text( this.abbreviateUri( value ) );
+
if ( this.isExploreUrl( value ) ) {
$html.prepend(
this.createExploreButton( value ), ' ' );
}
@@ -314,6 +313,7 @@
*/
SELF.prototype.handleCommonResourceItem = function( e ) {
e.preventDefault();
+
$( this ).ekkoLightbox( {
'scale_height': true
} );
diff --git a/wikibase/queryService/ui/visualEditor/SelectorBox.js
b/wikibase/queryService/ui/visualEditor/SelectorBox.js
index 7de9433..e1bf521 100644
--- a/wikibase/queryService/ui/visualEditor/SelectorBox.js
+++ b/wikibase/queryService/ui/visualEditor/SelectorBox.js
@@ -39,7 +39,6 @@
* @param {Object} toolbar {icon:callback}
*/
SELF.prototype.add = function( $element, listener, toolbar ) {
-
switch ( $element.data( 'type' ).toLowerCase() ) {
case 'number':
this._createInput( $element, listener, toolbar );
@@ -99,7 +98,6 @@
return $content;
}
} ).click( function( e ) {
-
$select.toggleClass( 'open' );
if ( !$select.data( 'select2' ) ) {
@@ -150,14 +148,14 @@
* @private
*/
SELF.prototype._getToolbar = function( toolbar, $element ) {
-
var $toolbar = $( '<span>' );
+
$.each( toolbar, function( icon, callback ) {
var $link = $( '<a>' ).attr( 'href', '#' );
$link.prepend( '<span class="glyphicon glyphicon-' +
icon +
'" aria-hidden="true"></span>', ' ' );
- $link.click( function() {
+ $link.click( function() {
if ( callback() ) {
$element.click();// close popover
}
diff --git a/wikibase/queryService/ui/visualEditor/SparqlQuery.js
b/wikibase/queryService/ui/visualEditor/SparqlQuery.js
index 2c9fb19..8f1440d 100644
--- a/wikibase/queryService/ui/visualEditor/SparqlQuery.js
+++ b/wikibase/queryService/ui/visualEditor/SparqlQuery.js
@@ -38,7 +38,6 @@
* @param {String} query SPARQL query string
*/
SELF.prototype.parse = function( query, prefixes ) {
-
var parser = new sparqljs.Parser( prefixes );
this._query = parser.parse( query );
};
@@ -89,7 +88,6 @@
* @param {string} name of variable e.g. ?foo
*/
SELF.prototype.hasVariable = function( name ) {
-
if ( this._query.variables.length === 0 ) {
return false;
}
@@ -111,7 +109,6 @@
* @param {string} name
*/
SELF.prototype.addVariable = function( name ) {
-
if ( !name.startsWith( '?' ) ) {
return;
}
@@ -133,7 +130,6 @@
* @param {string} name
*/
SELF.prototype.removeVariable = function( name ) {
-
if ( !name.startsWith( '?' ) ) {
return;
}
@@ -235,13 +231,13 @@
}
]
};
+
if ( isOptional ) {
var optionalTriple = {
type: 'optional',
patterns: [
triple
]
-
};
this._query.where.push( optionalTriple );
} else {
diff --git a/wikibase/queryService/ui/visualEditor/VisualEditor.js
b/wikibase/queryService/ui/visualEditor/VisualEditor.js
index 507e016..6d87cc9 100644
--- a/wikibase/queryService/ui/visualEditor/VisualEditor.js
+++ b/wikibase/queryService/ui/visualEditor/VisualEditor.js
@@ -165,8 +165,8 @@
* @param {jQuery} $element
*/
SELF.prototype.draw = function( $element ) {
-
this._triples = this._query.getTriples();
+
var subqueries = this._query.getSubQueries();
while ( subqueries.length > 0 ) {
var q = subqueries.pop();
@@ -191,7 +191,6 @@
* @private
*/
SELF.prototype._i18n = function( key ) {
-
if ( !$.i18n ) {
return this._labels[key];
}
@@ -221,6 +220,7 @@
$show.append( self._getTripleHtml( triple ) );
return;
}
+
if ( $find.children().length > 1 ) {
if ( $find.children().length === 2 ) {
$find.append( $( '<span>' ).text(
self._i18n( 'with' ) + ' ' ) );
@@ -228,8 +228,8 @@
$find.append( $( '<span>' ).text(
self._i18n( 'and' ) + ' ' ) );
}
}
- $find.append( self._getTripleHtml( triple ) );
+ $find.append( self._getTripleHtml( triple ) );
} );
if ( $find.children().length === 1 ) {
@@ -364,7 +364,6 @@
* @private
*/
SELF.prototype._isNotRelevant = function( triple ) {
-
if ( FILTER_PREDICATES[triple.predicate] ) {
return true;
}
@@ -382,7 +381,6 @@
* @private
*/
SELF.prototype._isInShowSection = function( triple ) {
-
// Must match ?value wdt:Pxx ?item
if ( this._isVariable( triple.subject ) && this._isVariable(
triple.object ) ) {
return true;
@@ -395,11 +393,10 @@
* @private
*/
SELF.prototype._getTripleHtml = function( triple ) {
- var self = this;
+ var self = this,
+ $triple = $( '<span>' );
- var $triple = $( '<span>' );
$.each( triple.triple, function( k, entity ) {
-
if ( self._isSimpleMode && self._isVariable( entity ) )
{
return;
}
@@ -437,7 +434,6 @@
self._isVariable( t.triple.object ) ===
false ) {
boundVariables[t.triple.subject] = true;
}
-
} );
if ( Object.keys( boundVariables ).length > 1 ) {
@@ -475,7 +471,6 @@
triple.triple = newTriple;
$path.append( self._getTripleEntityHtml( v, triple, k )
);
-
} );
return $path;
diff --git a/wikibase/tests/queryService/ui/editor/hint/Rdf.test.js
b/wikibase/tests/queryService/ui/editor/hint/Rdf.test.js
index e4331fc..b01744d 100644
--- a/wikibase/tests/queryService/ui/editor/hint/Rdf.test.js
+++ b/wikibase/tests/queryService/ui/editor/hint/Rdf.test.js
@@ -86,5 +86,4 @@
} );
} );
-
}( jQuery, QUnit, sinon, wikibase ) );
diff --git a/wikibase/tests/queryService/ui/resultBrowser/ResultBrowser.test.js
b/wikibase/tests/queryService/ui/resultBrowser/ResultBrowser.test.js
index 5481667..418f360 100644
--- a/wikibase/tests/queryService/ui/resultBrowser/ResultBrowser.test.js
+++ b/wikibase/tests/queryService/ui/resultBrowser/ResultBrowser.test.js
@@ -26,7 +26,7 @@
// TreeMapResultBrowser: '<svg width=\"2061\" height=\"756\"><g><g
class=\"cell parent\"><rect width=\"2061\" height=\"20\" style=\"fill: rgb(85,
85, 85);\"></rect><foreignObject class=\"foreignObject\"><body
class=\"labelbody\"><div class=\"label\" style=\"display:
block;\"></div></body></foreignObject></g><g class=\"cell parent\"><rect
width=\"2061\" height=\"20\" style=\"fill: rgb(85, 85,
85);\"></rect><foreignObject class=\"foreignObject\"><body
class=\"labelbody\"><div class=\"label\" style=\"display:
block;\"></div></body></foreignObject></g><g class=\"cell parent\"><rect
width=\"2061\" height=\"20\" style=\"fill: rgb(85, 85,
85);\"></rect><foreignObject class=\"foreignObject\"><body
class=\"labelbody\"><div class=\"label\" style=\"display:
block;\"></div></body></foreignObject></g><g class=\"cell child\"><rect
class=\"background\" style=\"fill: rgb(31, 119, 180);\"></rect><foreignObject
class=\"foreignObject\" width=\"1030.5\" height=\"756\"><body
class=\"labelbody\"><div class=\"label\" style=\"display:
block;\">AdventuresinBaby-Getting</div></body></foreignObject></g><g
class=\"cell child\"><rect class=\"background\" style=\"fill: rgb(31, 119,
180);\"></rect><foreignObject class=\"foreignObject\" width=\"1030.5\"
height=\"756\"><body class=\"labelbody\"><div class=\"label\" style=\"display:
block;\">MoonshineRiver</div></body></foreignObject></g></g></svg>',
// };
- $.each( browsers, function( index, browser ){
+ $.each( browsers, function( index, browser ) {
QUnit.test( 'When instantiating ' + browser + ' there should be
no error ', function( assert ) {
var b = new resultBrowser[ browser ]();
diff --git a/wikibase/tests/queryService/ui/visualEditor/SparqlQuery.test.js
b/wikibase/tests/queryService/ui/visualEditor/SparqlQuery.test.js
index 3132f16..f9c313c 100644
--- a/wikibase/tests/queryService/ui/visualEditor/SparqlQuery.test.js
+++ b/wikibase/tests/queryService/ui/visualEditor/SparqlQuery.test.js
@@ -159,7 +159,6 @@
"predicate": "PU2",
"object": "OU2"
}, 'triple3 must be SU2, PU2, OU2' );
-
} );
QUnit.test( 'When query is \'' + QUERY.TRIPLES + '\' and I delete 2
triples then', function(
@@ -198,7 +197,6 @@
assert.equal( queries.length, 1, 'expecting one sub query of
sub query' );
assert.ok( ( queries[0] instanceof PACKAGE.SparqlQuery ),
'that must be instance of SparqlQuery' );
-
} );
QUnit.test( 'When query is \'' + QUERY.TRIPLES + '\' and I add two
triples',
diff --git a/wikibase/tests/queryService/ui/visualEditor/VisualEditor.test.js
b/wikibase/tests/queryService/ui/visualEditor/VisualEditor.test.js
index 8622231..e803afa 100644
--- a/wikibase/tests/queryService/ui/visualEditor/VisualEditor.test.js
+++ b/wikibase/tests/queryService/ui/visualEditor/VisualEditor.test.js
@@ -89,7 +89,6 @@
assert.equal( ve.getQuery().trim(), testCase.sparqlOut
);
assert.equal( $html.text().trim(), testCase.text );
} );
-
} );
}( jQuery, QUnit, sinon, wikibase ) );
--
To view, visit https://gerrit.wikimedia.org/r/303994
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2fac25d997131b0ca7cdf2a79972c85798fbe72
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
