Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/304144
Change subject: Use `a` tag for clear icon
......................................................................
Use `a` tag for clear icon
It seems mw-ui-icon and the button tag do not cooperate (reason
unknown)
There is no reason this needs to be a button tag. Unless someone
can identify which browser style is interfering with vertical alignment
this seems a safe fix.
Bug: T142391
Change-Id: I0c32eaa3c4015d178c0caae82741aa4996f368f2
---
M resources/mobile.search/SearchOverlay.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/44/304144/1
diff --git a/resources/mobile.search/SearchOverlay.js
b/resources/mobile.search/SearchOverlay.js
index d997cda..894fff2 100644
--- a/resources/mobile.search/SearchOverlay.js
+++ b/resources/mobile.search/SearchOverlay.js
@@ -61,7 +61,7 @@
*/
defaults: $.extend( {}, Overlay.prototype.defaults, {
clearIcon: new Icon( {
- tagName: 'button',
+ tagName: 'a',
name: 'clear',
label: mw.msg( 'mobile-frontend-clear-search' ),
additionalClassNames: 'clear'
--
To view, visit https://gerrit.wikimedia.org/r/304144
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0c32eaa3c4015d178c0caae82741aa4996f368f2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
