jenkins-bot has submitted this change and it was merged.

Change subject: Use ipb_id when updating expiry in Block::updateTimestamp()
......................................................................


Use ipb_id when updating expiry in Block::updateTimestamp()

If Block::purgeExpired() hasn't been called due to low traffic, already
expired blocks might have their timestamps extended.

Bug: T128695
Change-Id: I21e7dca57bda77a755b54d0e09f340c3f0e75bd6
---
M includes/Block.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/Block.php b/includes/Block.php
index c5a16fc..f91f4bd 100644
--- a/includes/Block.php
+++ b/includes/Block.php
@@ -843,7 +843,7 @@
                                        'ipb_expiry' => $dbw->timestamp( 
$this->mExpiry ),
                                ),
                                array( /* WHERE */
-                                       'ipb_address' => 
(string)$this->getTarget()
+                                       'ipb_id' => $this->getId()
                                ),
                                __METHOD__
                        );

-- 
To view, visit https://gerrit.wikimedia.org/r/304114
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I21e7dca57bda77a755b54d0e09f340c3f0e75bd6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_26
Gerrit-Owner: Chad <ch...@wikimedia.org>
Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to