jenkins-bot has submitted this change and it was merged.
Change subject: Hygiene: remove a couple stub methods
......................................................................
Hygiene: remove a couple stub methods
Change-Id: I40dba95188d3fde799fe1d2836dfbc8937a68af1
---
M app/src/main/java/org/wikipedia/page/gallery/GalleryActivity.java
M app/src/main/java/org/wikipedia/readinglist/ReadingListsFragment.java
2 files changed, 2 insertions(+), 13 deletions(-)
Approvals:
Dbrant: Looks good to me, approved
jenkins-bot: Verified
diff --git a/app/src/main/java/org/wikipedia/page/gallery/GalleryActivity.java
b/app/src/main/java/org/wikipedia/page/gallery/GalleryActivity.java
index ac84953..01eef87 100644
--- a/app/src/main/java/org/wikipedia/page/gallery/GalleryActivity.java
+++ b/app/src/main/java/org/wikipedia/page/gallery/GalleryActivity.java
@@ -278,11 +278,8 @@
unregisterReceiver(downloadReceiver);
}
- private class GalleryPageChangeListener implements
ViewPager.OnPageChangeListener {
+ private class GalleryPageChangeListener extends
ViewPager.SimpleOnPageChangeListener {
private int currentPosition = -1;
- @Override
- public void onPageScrolled(int position, float positionOffset, int
positionOffsetPixels) {
- }
@Override
public void onPageSelected(int position) {
// the pager has settled on a new position
diff --git
a/app/src/main/java/org/wikipedia/readinglist/ReadingListsFragment.java
b/app/src/main/java/org/wikipedia/readinglist/ReadingListsFragment.java
index d98afab..5a1972c 100644
--- a/app/src/main/java/org/wikipedia/readinglist/ReadingListsFragment.java
+++ b/app/src/main/java/org/wikipedia/readinglist/ReadingListsFragment.java
@@ -89,18 +89,10 @@
pager = (ViewPager) rootView.findViewById(R.id.pager);
pager.setAdapter(pagerAdapter);
- pager.addOnPageChangeListener(new ViewPager.OnPageChangeListener() {
- @Override
- public void onPageScrolled(int position, float positionOffset, int
positionOffsetPixels) {
- }
-
+ pager.addOnPageChangeListener(new
ViewPager.SimpleOnPageChangeListener() {
@Override
public void onPageSelected(int position) {
getActivity().supportInvalidateOptionsMenu();
- }
-
- @Override
- public void onPageScrollStateChanged(int state) {
}
});
--
To view, visit https://gerrit.wikimedia.org/r/304039
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I40dba95188d3fde799fe1d2836dfbc8937a68af1
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
