Aaron Schulz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/304258
Change subject: Use waitForAll() for slow JobRunner commits
......................................................................
Use waitForAll() for slow JobRunner commits
Using waitForOne() barely goes beyond semi-sync replication
already in place on serious DB clusters.
Change-Id: Idb719deaa5993bc2f818cd110d49d09567e0afb3
---
M includes/jobqueue/JobRunner.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/58/304258/1
diff --git a/includes/jobqueue/JobRunner.php b/includes/jobqueue/JobRunner.php
index a132dc5..23eb7c7 100644
--- a/includes/jobqueue/JobRunner.php
+++ b/includes/jobqueue/JobRunner.php
@@ -525,7 +525,7 @@
// Wait for the generic slave to catch up
$pos = $lb->getMasterPos();
if ( $pos ) {
- $lb->waitForOne( $pos );
+ $lb->waitForAll( $pos );
}
$fname = __METHOD__;
--
To view, visit https://gerrit.wikimedia.org/r/304258
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idb719deaa5993bc2f818cd110d49d09567e0afb3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
