jenkins-bot has submitted this change and it was merged.
Change subject: Deprecate various ResourceLoader modules
......................................................................
Deprecate various ResourceLoader modules
Various modules in MediaWiki core replicate functionality elsewhere.
To improve consistency with how we build things and how things appear
in the frontend we need to guide engineers and gadget developers to use
the same libraries. No deprecation dates are given for these modules
but this is hoped to be the starting point for some good conversations
that will guide us to better frontend development
If a module depends on a deprecated module, it itself is not marked
as deprecated
Bug: T142418
Change-Id: Ibbfcfde64072e7d3e3ee5ecb7f966fd889259798
---
M resources/Resources.php
1 file changed, 9 insertions(+), 0 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/Resources.php b/resources/Resources.php
index 1558ee6..d3e58e1 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -333,6 +333,9 @@
'targets' => [ 'desktop', 'mobile' ],
],
'jquery.jStorage' => [
+ 'deprecated' => [
+ 'message' => 'Please use "mediawiki.storage" instead.',
+ ],
'scripts' => 'resources/lib/jquery/jquery.jStorage.js',
'dependencies' => 'json',
],
@@ -370,6 +373,7 @@
/* jQuery Tipsy */
'jquery.tipsy' => [
+ 'deprecated' => true,
'scripts' => 'resources/src/jquery.tipsy/jquery.tipsy.js',
'styles' => 'resources/src/jquery.tipsy/jquery.tipsy.css',
],
@@ -377,6 +381,9 @@
/* jQuery UI */
'jquery.ui.core' => [
+ 'deprecated' => [
+ 'message' => 'Please use "mediawiki.ui.button" or
"oojs-ui" instead.',
+ ],
'scripts' => 'resources/lib/jquery.ui/jquery.ui.core.js',
'dependencies' => [
'jquery.ui.core.styles',
@@ -655,11 +662,13 @@
'group' => 'jquery.ui',
],
'jquery.ui.widget' => [
+ 'deprecated' => true,
'scripts' => 'resources/lib/jquery.ui/jquery.ui.widget.js',
'group' => 'jquery.ui',
],
// Effects
'jquery.effects.core' => [
+ 'deprecated' => true,
'scripts' => 'resources/lib/jquery.ui/jquery.ui.effect.js',
'group' => 'jquery.ui',
],
--
To view, visit https://gerrit.wikimedia.org/r/302732
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibbfcfde64072e7d3e3ee5ecb7f966fd889259798
Gerrit-PatchSet: 6
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Trevor Parscal <tpars...@wikimedia.org>
Gerrit-Reviewer: VolkerE <volke...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
