Yuvipanda has uploaded a new change for review.
https://gerrit.wikimedia.org/r/304434
Change subject: labs: Don't collect network stats by default
......................................................................
labs: Don't collect network stats by default
We aren't really using them atm
Change-Id: I2ca0d3f91086f9540679010db97aaef06856fe9e
---
M modules/diamond/files/collector/libvirtkvm.py
1 file changed, 13 insertions(+), 11 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/34/304434/1
diff --git a/modules/diamond/files/collector/libvirtkvm.py
b/modules/diamond/files/collector/libvirtkvm.py
index 5957393..37600db 100644
--- a/modules/diamond/files/collector/libvirtkvm.py
+++ b/modules/diamond/files/collector/libvirtkvm.py
@@ -66,7 +66,8 @@
'path': 'libvirt-kvm',
'sort_by_uuid': False,
'uri': 'qemu:///system',
- 'cpu_absolute': False
+ 'cpu_absolute': False,
+ 'network_stats': False
})
return config
@@ -147,17 +148,18 @@
for stat in self.vifStats.keys():
accum[stat] = 0
- for vif in vifs:
- stats = dom.interfaceStats(vif)
+ if self.config['network_stats']:
+ for vif in vifs:
+ stats = dom.interfaceStats(vif)
+ for stat in self.vifStats.keys():
+ idx = self.vifStats[stat]
+ val = stats[idx]
+ accum[stat] += val
+ self.publish('net.%s.%s' % (vif, stat), val,
+ instance=name)
for stat in self.vifStats.keys():
- idx = self.vifStats[stat]
- val = stats[idx]
- accum[stat] += val
- self.publish('net.%s.%s' % (vif, stat), val,
- instance=name)
- for stat in self.vifStats.keys():
- self.publish('net.total.%s' % stat, accum[stat],
- instance=name)
+ self.publish('net.total.%s' % stat, accum[stat],
+ instance=name)
# Memory stats
mem = dom.memoryStats()
--
To view, visit https://gerrit.wikimedia.org/r/304434
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ca0d3f91086f9540679010db97aaef06856fe9e
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Yuvipanda <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
