Addshore has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/304454

Change subject: Also track the hook run count
......................................................................

Also track the hook run count

This will give us a better idea of how many times the
slider is being sent out in by the php code as oposed
to how many times the JS code is running.

This number is important as client side the code will
listed to things like DoNotTrack and not send data!

The difference between the initphp and init numbers
should give us an idea of how often this is heppening!

Change-Id: I01db4318b08851de4c6b8c96cbf2740324160140
---
M RevisionSlider.hooks.php
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RevisionSlider 
refs/changes/54/304454/1

diff --git a/RevisionSlider.hooks.php b/RevisionSlider.hooks.php
index 0746d05..cd6104b 100644
--- a/RevisionSlider.hooks.php
+++ b/RevisionSlider.hooks.php
@@ -34,6 +34,9 @@
                        return true;
                }
 
+               $stats = 
MediaWikiServices::getInstance()->getStatsdDataFactory();
+               $stats->increment( 'RevisionSlider.event.hookinit' );
+
                $config = MediaWikiServices::getInstance()->getMainConfig();
                $timeOffset = $config->get( 'LocalTZoffset' );
                if ( is_null( $config->get( 'Localtimezone' ) ) ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/304454
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I01db4318b08851de4c6b8c96cbf2740324160140
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to