Ejegg has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/304499

Change subject: De-duplicate IncomingMessage action
......................................................................

De-duplicate IncomingMessage action

Change-Id: I0a1b311fdfa6c3d1968cf7e0ae21aa18f4c994ad
---
R Core/Actions/IncomingMessage.php
D PaymentProviders/GlobalCollect/Actions/IncomingMessage.php
M SmashPig.yaml
3 files changed, 3 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/SmashPig 
refs/changes/99/304499/1

diff --git a/PaymentProviders/AstroPay/Actions/IncomingMessage.php 
b/Core/Actions/IncomingMessage.php
similarity index 84%
rename from PaymentProviders/AstroPay/Actions/IncomingMessage.php
rename to Core/Actions/IncomingMessage.php
index 3baa477..61adc23 100644
--- a/PaymentProviders/AstroPay/Actions/IncomingMessage.php
+++ b/Core/Actions/IncomingMessage.php
@@ -1,6 +1,5 @@
-<?php namespace SmashPig\PaymentProviders\AstroPay\Actions;
+<?php namespace SmashPig\Core\Actions;
 
-use SmashPig\Core\Actions\IListenerMessageAction;
 use SmashPig\Core\Context;
 use SmashPig\Core\Logging\Logger;
 use SmashPig\Core\Messages\ListenerMessage;
diff --git a/PaymentProviders/GlobalCollect/Actions/IncomingMessage.php 
b/PaymentProviders/GlobalCollect/Actions/IncomingMessage.php
deleted file mode 100644
index 418401f..0000000
--- a/PaymentProviders/GlobalCollect/Actions/IncomingMessage.php
+++ /dev/null
@@ -1,24 +0,0 @@
-<?php namespace SmashPig\PaymentProviders\GlobalCollect\Actions;
-
-use SmashPig\Core\Actions\IListenerMessageAction;
-use SmashPig\Core\Context;
-use SmashPig\Core\Logging\Logger;
-use SmashPig\Core\Messages\ListenerMessage;
-
-class IncomingMessage implements IListenerMessageAction {
-       public function execute( ListenerMessage $msg ) {
-               $destinationQueue = $msg->getDestinationQueue();
-
-               if ( $destinationQueue ) {
-                       $queue = Context::get()->getConfiguration()->object( 
"data-store/{$destinationQueue}" );
-                       $queueMsg = $msg->normalizeForQueue();
-
-                       $queue->push( $queueMsg );
-               } else {
-                       $class = get_class( $msg );
-                       Logger::warning( "Ignoring message of type {$class}", 
$msg );
-               }
-
-               return true;
-       }
-}
diff --git a/SmashPig.yaml b/SmashPig.yaml
index 148a8a4..0fcfc34 100644
--- a/SmashPig.yaml
+++ b/SmashPig.yaml
@@ -326,7 +326,7 @@
 
 astropay:
     actions:
-        - SmashPig\PaymentProviders\AstroPay\Actions\IncomingMessage
+        - SmashPig\Core\Actions\IncomingMessage
 
     endpoints:
         listener:
@@ -350,7 +350,7 @@
 
 globalcollect:
     actions:
-        - SmashPig\PaymentProviders\GlobalCollect\Actions\IncomingMessage
+        - SmashPig\Core\Actions\IncomingMessage
 
     endpoints:
         listener:

-- 
To view, visit https://gerrit.wikimedia.org/r/304499
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a1b311fdfa6c3d1968cf7e0ae21aa18f4c994ad
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/SmashPig
Gerrit-Branch: master
Gerrit-Owner: Ejegg <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to