jenkins-bot has submitted this change and it was merged.
Change subject: QuerySamples parser: remove not needed escaping
......................................................................
QuerySamples parser: remove not needed escaping
These are actually assisted by PHPStorm. The equal sign does not have
a special meaning in regular expressions. A closing } does not have a
meaning when there is no opening {.
Change-Id: Ib5631a4e4e7584559bd459468bfe69dcdc7f41c3
---
M wikibase/queryService/api/QuerySamples.js
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Smalyshev: Looks good to me, approved
jenkins-bot: Verified
diff --git a/wikibase/queryService/api/QuerySamples.js
b/wikibase/queryService/api/QuerySamples.js
index e47249a..217ef3f 100644
--- a/wikibase/queryService/api/QuerySamples.js
+++ b/wikibase/queryService/api/QuerySamples.js
@@ -40,7 +40,7 @@
.done(
function ( data ) {
var wikitext =
data.query.pages[Object.keys( data.query.pages )].revisions[0]['*'];
- wikitext = wikitext.replace(
/\{\{!\}\}/g, '|' );
+ wikitext = wikitext.replace(
/\{\{!}}/g, '|' );
deferred.resolve( self._extract(
wikitext ) );
} );
@@ -76,9 +76,9 @@
* @private
*/
SELF.prototype._extractExamples = function ( section, sectionHeader ) {
- var regexParagraph =
/(?:[\=]+)([^\=]*)(?:[\=]+)\n(?:[]*?)(?:[^=]*?)(\{\{SPARQL\s*\|[\s\S]*?}}\n){1}/g,
- regexQuery = /query\s*\=([^]+)(?:}}|\|)/,
- regexExtraPrefix = /extraprefix\s*\=([^]+?)(?:\||}})+/,
+ var regexParagraph =
/(?:[=]+)([^=]*)(?:[=]+)\n(?:[]*?)(?:[^=]*?)(\{\{SPARQL\s*\|[\s\S]*?}}\n){1}/g,
+ regexQuery = /query\s*=([^]+)(?:}}|\|)/,
+ regexExtraPrefix = /extraprefix\s*=([^]+?)(?:\||}})+/,
regexTags = /\{\{Q\|([^]+?)\|([^]+?)}}+/g,
m,
examples = [];
--
To view, visit https://gerrit.wikimedia.org/r/304216
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5631a4e4e7584559bd459468bfe69dcdc7f41c3
Gerrit-PatchSet: 2
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Smalyshev <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
