jenkins-bot has submitted this change and it was merged.
Change subject: Don't register EventLogging schema modules directly
......................................................................
Don't register EventLogging schema modules directly
Don't directly register the EventLogging schema.* modules, as hardcodes
specifics about that extension. Instead, use the "EventLoggingSchemas"
attribute to register them with the EventLogging extension, which will
take care of registering them as ResourceLoader modules.
Change-Id: I416dc62289f359ed5e677ee84e044be7a44d374c
---
M extension.json
1 file changed, 10 insertions(+), 40 deletions(-)
Approvals:
Mattflaschen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/extension.json b/extension.json
index a6f6d14..db29187 100644
--- a/extension.json
+++ b/extension.json
@@ -41,11 +41,6 @@
"GettingStarted\\TaskRecommendationsExperimentV1":
"TaskRecommendationsExperimentV1.php"
},
"ResourceModules": {
- "schema.GettingStartedRedirectImpression": {
- "class": "ResourceLoaderSchemaModule",
- "schema": "GettingStartedRedirectImpression",
- "revision": 7355552
- },
"ext.guidedTour.tour.gettingstartedtasktoolbar": {
"scripts": "tours/gettingstartedtasktoolbar.js",
"dependencies": [
@@ -225,47 +220,22 @@
"mediawiki.user"
],
"position": "top"
- },
- "schema.SignupExpPageLinkClick": {
- "class": "ResourceLoaderSchemaModule",
- "schema": "SignupExpPageLinkClick",
- "revision": 8965014
- },
- "schema.SignupExpCTAImpression": {
- "class": "ResourceLoaderSchemaModule",
- "schema": "SignupExpCTAImpression",
- "revision": 8965023
- },
- "schema.SignupExpCTAButtonClick": {
- "class": "ResourceLoaderSchemaModule",
- "schema": "SignupExpCTAButtonClick",
- "revision": 8965028
- },
- "schema.TaskRecommendationLightbulbClick": {
- "class": "ResourceLoaderSchemaModule",
- "schema": "TaskRecommendationLightbulbClick",
- "revision": 9433256
- },
- "schema.TaskRecommendationImpression": {
- "class": "ResourceLoaderSchemaModule",
- "schema": "TaskRecommendationImpression",
- "revision": 9266226
- },
- "schema.TaskRecommendation": {
- "class": "ResourceLoaderSchemaModule",
- "schema": "TaskRecommendation",
- "revision": 9266319
- },
- "schema.TaskRecommendationClick": {
- "class": "ResourceLoaderSchemaModule",
- "schema": "TaskRecommendationClick",
- "revision": 9266317
}
},
"ResourceFileModulePaths": {
"localBasePath": "resources",
"remoteExtPath": "GettingStarted/resources"
},
+ "EventLoggingSchemas": {
+ "GettingStartedRedirectImpression": 7355552,
+ "SignupExpCTAButtonClick": 8965028,
+ "SignupExpCTAImpression": 8965023,
+ "SignupExpPageLinkClick": 8965014,
+ "TaskRecommendation": 9266319,
+ "TaskRecommendationClick": 9266317,
+ "TaskRecommendationImpression": 9266226,
+ "TaskRecommendationLightbulbClick": 9433256
+ },
"Hooks": {
"BeforePageDisplay":
"GettingStarted\\Hooks::onBeforePageDisplay",
"CategoryAfterPageAdded":
"GettingStarted\\RedisCategorySync::onCategoryAfterPageAdded",
--
To view, visit https://gerrit.wikimedia.org/r/303985
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I416dc62289f359ed5e677ee84e044be7a44d374c
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/GettingStarted
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: Phuedx <[email protected]>
Gerrit-Reviewer: Swalling <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
