WMDE-leszek has uploaded a new change for review.
https://gerrit.wikimedia.org/r/304816
Change subject: Do not make progress bar with zero progress indeterminate
......................................................................
Do not make progress bar with zero progress indeterminate
Per docs only setting a progress to false should imply
the progress bar is indeterminate.
Change-Id: Id909f31135e2106c0505dcc82e44a06a3993698b
---
M src/widgets/ProgressBarWidget.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/16/304816/1
diff --git a/src/widgets/ProgressBarWidget.js b/src/widgets/ProgressBarWidget.js
index 1b6ea78..fc1b029 100644
--- a/src/widgets/ProgressBarWidget.js
+++ b/src/widgets/ProgressBarWidget.js
@@ -92,5 +92,5 @@
this.$bar.css( 'width', '' );
this.$element.removeAttr( 'aria-valuenow' );
}
- this.$element.toggleClass( 'oo-ui-progressBarWidget-indeterminate',
!progress );
+ this.$element.toggleClass( 'oo-ui-progressBarWidget-indeterminate',
progress === false );
};
--
To view, visit https://gerrit.wikimedia.org/r/304816
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id909f31135e2106c0505dcc82e44a06a3993698b
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: WMDE-leszek <leszek.mani...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
