jenkins-bot has submitted this change and it was merged.
Change subject: Avoid undefined variable warnings
......................................................................
Avoid undefined variable warnings
We had protected the code with isset, but it wasn't good enuf for static
analysis
Change-Id: Iba39ad4f304f43f998f9476fb9dab99c92e5ec32
---
M globalcollect_gateway/globalcollect.adapter.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Ejegg: Looks good to me, approved
jenkins-bot: Verified
diff --git a/globalcollect_gateway/globalcollect.adapter.php
b/globalcollect_gateway/globalcollect.adapter.php
index 8c09648..5bc580e 100644
--- a/globalcollect_gateway/globalcollect.adapter.php
+++ b/globalcollect_gateway/globalcollect.adapter.php
@@ -665,6 +665,7 @@
$loopcount = $this->getGlobal( 'RetryLoopCount' );
$loops = 0;
+ $status_response = null;
for ( $loops = 0; $loops < $loopcount && !$cancelflag &&
!$problemflag; ++$loops ){
$gotCVV = false;
@@ -800,7 +801,7 @@
//if we got here with no problemflag,
//confirm or cancel the payment based on $cancelflag
if ( !$problemflag ){
- if ( isset( $status_response ) && is_array(
$status_response ) ) {
+ if ( is_array( $status_response ) ) {
// FIXME: Refactor as normal unstaging.
//if they're set, get CVVRESULT && AVSRESULT
$pull_vars['EFFORTID'] = 'effort_id';
--
To view, visit https://gerrit.wikimedia.org/r/304589
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iba39ad4f304f43f998f9476fb9dab99c92e5ec32
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Awight <[email protected]>
Gerrit-Reviewer: AndyRussG <[email protected]>
Gerrit-Reviewer: Cdentinger <[email protected]>
Gerrit-Reviewer: Ejegg <[email protected]>
Gerrit-Reviewer: Ssmith <[email protected]>
Gerrit-Reviewer: XenoRyet <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
