Gilles has uploaded a new change for review.
https://gerrit.wikimedia.org/r/304995
Change subject: Delay thumbnail pre rendering job by a second
......................................................................
Delay thumbnail pre rendering job by a second
Currently we seem to be hitting a race condition sometimes where
Swift may report the original as missing when asked immediately after
it being uploaded. Status is usually reported correctly on
other jobs in the same batch, all within the timeframe of a second.
Bug: T106740
Change-Id: If46484ab1c83cf12ab30ab9c194759c532b24009
---
M includes/upload/UploadBase.php
1 file changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/95/304995/1
diff --git a/includes/upload/UploadBase.php b/includes/upload/UploadBase.php
index 1185c4d..efc0693 100644
--- a/includes/upload/UploadBase.php
+++ b/includes/upload/UploadBase.php
@@ -762,9 +762,16 @@
foreach ( $sizes as $size ) {
if ( $file->isVectorized() || $file->getWidth() > $size
) {
+ $params = [
+ 'transformParams' => [ 'width' => $size
],
+ // Delay the job start because the
original can be
+ // unreadable immediately after being
uploaded
+ 'jobReleaseTimestamp' => strtotime( '+1
second' )
+ ];
+
$jobs[] = new ThumbnailRenderJob(
$file->getTitle(),
- [ 'transformParams' => [ 'width' =>
$size ] ]
+ $params
);
}
}
--
To view, visit https://gerrit.wikimedia.org/r/304995
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If46484ab1c83cf12ab30ab9c194759c532b24009
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gilles <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
