Jhernandez has uploaded a new change for review.
https://gerrit.wikimedia.org/r/304998
Change subject: Combine resize handlers into the global one
......................................................................
Combine resize handlers into the global one
In order to keep the number of handlers attached on resize to the window, let's
use the events in mw.mobileFrontend so that there is only one handler attached
to the window.
This moves the handlers on the image overlay and the pointer overlay to use the
global event handler (using 'resize' when debounced or 'resize:throttled' when
needed)
Bug: T124870
Change-Id: I897275a8d320a72cc7fefae4bdcfe5f5d6ed34e3
---
M resources/mobile.mediaViewer/ImageOverlay.js
M resources/mobile.pointerOverlay/PointerOverlay.js
2 files changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/98/304998/1
diff --git a/resources/mobile.mediaViewer/ImageOverlay.js
b/resources/mobile.mediaViewer/ImageOverlay.js
index 7ef7bc3..4d9f805 100644
--- a/resources/mobile.mediaViewer/ImageOverlay.js
+++ b/resources/mobile.mediaViewer/ImageOverlay.js
@@ -175,7 +175,7 @@
self.adjustDetails();
} );
- $( window ).on( 'resize', $.proxy( this,
'_positionImage' ) );
+ M.on( 'resize:throttled', $.proxy( this,
'_positionImage' ) );
},
/**
diff --git a/resources/mobile.pointerOverlay/PointerOverlay.js
b/resources/mobile.pointerOverlay/PointerOverlay.js
index 6bffce2..ffff307 100644
--- a/resources/mobile.pointerOverlay/PointerOverlay.js
+++ b/resources/mobile.pointerOverlay/PointerOverlay.js
@@ -136,8 +136,10 @@
// Since the positioning of this overlay is dependent
on the current viewport it makes sense to
// use a global window event so that on resizes it is
correctly positioned.
- $( window )
- .on( 'resize', $.debounce( 100, $.proxy( this,
'refreshPointerArrow', this.options.target ) ) );
+ M.on(
+ 'resize',
+ $.proxy( this, 'refreshPointerArrow',
this.options.target )
+ );
}
} );
--
To view, visit https://gerrit.wikimedia.org/r/304998
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I897275a8d320a72cc7fefae4bdcfe5f5d6ed34e3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jhernandez <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
