Phuedx has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/305015

Change subject: Remove jQuery.jStorage shim
......................................................................

Remove jQuery.jStorage shim

Per the FIXME above, it should've been removed midway through June.

Bug: T136241
Change-Id: I10723f9067c2573786270cd40fe012adb8c19c8b
---
M resources/ext.popups.targets/desktopTarget.js
1 file changed, 1 insertion(+), 20 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/15/305015/1

diff --git a/resources/ext.popups.targets/desktopTarget.js 
b/resources/ext.popups.targets/desktopTarget.js
index 02fbd19..db05b3a 100644
--- a/resources/ext.popups.targets/desktopTarget.js
+++ b/resources/ext.popups.targets/desktopTarget.js
@@ -171,26 +171,7 @@
        }
 
        $( function () {
-               var jStorage = mw.storage.get( 'jStorage' );
-
-               // FIXME: Can be removed a month from jStorage removal. Not 
perfect but should work in most cases.
-               if ( jStorage && jStorage.indexOf( 'popups-enabled' ) > 0 ) {
-                       // slower loading popups when in transition mode
-                       mw.loader.using( 'jquery.jStorage' ).done( function () {
-                               var val = $.jStorage.get( 'mwe-popups-enabled' 
);
-                               // delete jStorage key
-                               $.jStorage.deleteKey( 'mwe-popups-enabled' );
-                               if ( val === 'false' ) {
-                                       // copy over
-                                       mw.storage.set( 'mwe-popups-enabled', 
'0' );
-                               } else {
-                                       if ( val ) {
-                                               mw.storage.set( 
'mwe-popups-enabled', '1' );
-                                       }
-                                       initPopups();
-                               }
-                       } );
-               } else if ( mw.popups.enabled ) {
+               if ( mw.popups.enabled ) {
                        initPopups();
                }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/305015
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I10723f9067c2573786270cd40fe012adb8c19c8b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to