WMDE-leszek has uploaded a new change for review.
https://gerrit.wikimedia.org/r/305018
Change subject: Flip the parameter name and its type in phpdoc of
MWEchoEventLogging
......................................................................
Flip the parameter name and its type in phpdoc of MWEchoEventLogging
Also adds a type hint to MWEchoEventLogging::actuallyLogTheEvent
parameter.
Change-Id: I7538083ec33b5c4538386da22550273d8e882a72
---
M includes/EventLogging.php
1 file changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/18/305018/1
diff --git a/includes/EventLogging.php b/includes/EventLogging.php
index afb162a..e527440 100644
--- a/includes/EventLogging.php
+++ b/includes/EventLogging.php
@@ -7,10 +7,10 @@
/**
* This is the only function that interacts with EventLogging
- * @param $schema string
- * @param $data array
+ * @param string $schema
+ * @param array $data
*/
- public static function actuallyLogTheEvent( $schema, $data ) {
+ public static function actuallyLogTheEvent( $schema, array $data ) {
global $wgEchoConfig;
EventLogging::logEvent( $schema,
$wgEchoConfig['eventlogging'][$schema]['revision'], $data );
@@ -18,9 +18,9 @@
/**
* Function for logging the event for Schema:Echo
- * @param $user User being notified.
- * @param $event EchoEvent to log detail about.
- * @param $deliveryMethod string containing either 'web' or 'email'
+ * @param User $user User being notified.
+ * @param EchoEvent $event Event to log detail about.
+ * @param string $deliveryMethod 'web' or 'email'
*/
public static function logSchemaEcho( User $user, EchoEvent $event,
$deliveryMethod ) {
global $wgEchoConfig, $wgEchoNotifications;
@@ -77,8 +77,8 @@
/**
* Function for logging the event for Schema:EchoEmail
- * @param $user User
- * @param $emailDeliveryMode string
+ * @param User $user
+ * @param string $emailDeliveryMode 'single' (default), 'daily_digest',
or 'weekly_digest'
*/
public static function logSchemaEchoMail( User $user,
$emailDeliveryMode = 'single' ) {
global $wgEchoConfig;
--
To view, visit https://gerrit.wikimedia.org/r/305018
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7538083ec33b5c4538386da22550273d8e882a72
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: WMDE-leszek <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
