jenkins-bot has submitted this change and it was merged.
Change subject: ExtJS / RL: Removed obsolete "wait-for-css"
......................................................................
ExtJS / RL: Removed obsolete "wait-for-css"
In the last version there was an issue with ExtJS code being executed
before ExtJS CSS was loaded completely. Since every calling code now uses
'Ext.onReady'-wrapper properly this is not an issue anymore.
In fact the implementation was more likely to cause issues as it
manipulates the state of 'ext.bluespice.extjs' directly.
This change removes the obsolete logic.
Change-Id: Ibd5412cb6106a22226167edc67900132ee157d58
---
M resources/bluespice.extjs/bluespice.extjs.fixes.css
M resources/bluespice.extjs/bluespice.extjs.js
2 files changed, 0 insertions(+), 33 deletions(-)
Approvals:
Mglaser: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/bluespice.extjs/bluespice.extjs.fixes.css
b/resources/bluespice.extjs/bluespice.extjs.fixes.css
index d3a4337..40244e5 100644
--- a/resources/bluespice.extjs/bluespice.extjs.fixes.css
+++ b/resources/bluespice.extjs/bluespice.extjs.fixes.css
@@ -101,6 +101,3 @@
.x-boundlist-item {
font-size: 13px;
}
-.bs-extjs-cssisready {
- display: inline;
-}
\ No newline at end of file
diff --git a/resources/bluespice.extjs/bluespice.extjs.js
b/resources/bluespice.extjs/bluespice.extjs.js
index 643be88..3df4cc3 100755
--- a/resources/bluespice.extjs/bluespice.extjs.js
+++ b/resources/bluespice.extjs/bluespice.extjs.js
@@ -113,34 +113,4 @@
};
bs.extjs = extjs;
-
- //Wait for the CSS dependencies to be loaded or ExtJS wont have
important
- //dimensions for calculating. mw.loader ignores CSS dependencies. See:
- //https://phabricator.wikimedia.org/T63852
- mw.loader.state( 'ext.bluespice.extjs', 'loading' );
-
- var deferred = $.Deferred();
- $.when( deferred ).then( function () {
- //CSS is loaded, ExtJS is ready
- mw.loader.state( 'ext.bluespice.extjs', 'ready' );
- $(d).trigger( 'BSExtJSReady', [ bs.extjs ] );
- });
-
- var bsextjsisCSSReady = function( deferred ) {
- var $dummy = $( '<div class="bs-extjs-cssisready">' )
- .appendTo( $( document.body ) );
- //bluespice.extjs.fixes.css:bs-extjs-cssisready
- if ( $dummy.css( 'display' ) === 'inline' ) {
- $dummy.remove();
- deferred.resolve();
- return;
- }
- $dummy.remove();
- setTimeout( function () {
- bsextjsisCSSReady( deferred );
- }, 100 );
- };
-
- bsextjsisCSSReady( deferred );
-
}( mediaWiki, blueSpice, jQuery, document ) );
--
To view, visit https://gerrit.wikimedia.org/r/305016
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd5412cb6106a22226167edc67900132ee157d58
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceFoundation
Gerrit-Branch: master
Gerrit-Owner: Robert Vogel <[email protected]>
Gerrit-Reviewer: Dvogel hallowelt <[email protected]>
Gerrit-Reviewer: Ljonka <[email protected]>
Gerrit-Reviewer: Mglaser <[email protected]>
Gerrit-Reviewer: Pwirth <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
