jenkins-bot has submitted this change and it was merged.
Change subject: Allow old revs due to revs appearing not in order
......................................................................
Allow old revs due to revs appearing not in order
Change-Id: Icc222ec420e6f5e1d29afaf09549b1cedf52da05
---
M gui
M
tools/src/main/java/org/wikidata/query/rdf/tool/change/RecentChangesPoller.java
2 files changed, 7 insertions(+), 5 deletions(-)
Approvals:
Smalyshev: Looks good to me, approved
jenkins-bot: Verified
diff --git a/gui b/gui
index 1615132..492bb0b 160000
--- a/gui
+++ b/gui
@@ -1 +1 @@
-Subproject commit 161513268c043af471a976ec8a70ceefd1bbf77e
+Subproject commit 492bb0baf8fcc1d2fbda164c3d58eadd475d24b3
diff --git
a/tools/src/main/java/org/wikidata/query/rdf/tool/change/RecentChangesPoller.java
b/tools/src/main/java/org/wikidata/query/rdf/tool/change/RecentChangesPoller.java
index d8e9cd0..20e2cc8 100644
---
a/tools/src/main/java/org/wikidata/query/rdf/tool/change/RecentChangesPoller.java
+++
b/tools/src/main/java/org/wikidata/query/rdf/tool/change/RecentChangesPoller.java
@@ -120,10 +120,12 @@
log.info("Skipping change in irrelevant namespace: {}",
rc);
continue;
}
- if (continueChange != null && rcid < continueChange.rcid()) {
- // We've already seen this change, since it has older rcid
- so skip it
- continue;
- }
+// Looks like we can not rely on changes appearing in order, so we have to
take them all and let SPARQL
+// sort out the dupes.
+// if (continueChange != null && rcid < continueChange.rcid()) {
+// // We've already seen this change, since it has older
rcid - so skip it
+// continue;
+// }
Date timestamp = df.parse(rc.get("timestamp").toString());
Change change;
if (rc.get("type").toString().equals("log") &&
(long)rc.get("revid") == 0) {
--
To view, visit https://gerrit.wikimedia.org/r/305750
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc222ec420e6f5e1d29afaf09549b1cedf52da05
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/rdf
Gerrit-Branch: master
Gerrit-Owner: Smalyshev <[email protected]>
Gerrit-Reviewer: Smalyshev <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
