[MediaWiki-commits] [Gerrit] oojs/ui[master]: Centralize properties at ButtonElement

[VolkerE (Code Review)]

VolkerE has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/305848

Change subject: Centralize properties at ButtonElement
......................................................................

Centralize properties at ButtonElement

Centralizing `display` and `vertical-align` at ButtonElement instead
repeatingly at each of the button widgets.

Change-Id: I530008f7f849b1ac7ee8393427d12ec811f19f6a
---
M src/styles/elements/ButtonElement.less
M src/styles/widgets/ButtonInputWidget.less
M src/styles/widgets/ButtonWidget.less
M src/styles/widgets/ToggleButtonWidget.less
4 files changed, 3 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/48/305848/1

diff --git a/src/styles/elements/ButtonElement.less 
b/src/styles/elements/ButtonElement.less
index 8ec645b..269dafe 100644
--- a/src/styles/elements/ButtonElement.less
+++ b/src/styles/elements/ButtonElement.less
@@ -1,6 +1,9 @@
 @import '../common';
 
 .oo-ui-buttonElement {
+       display: inline-block;
+       vertical-align: middle;
+
        > .oo-ui-buttonElement-button {
                cursor: pointer;
                display: inline-block;
diff --git a/src/styles/widgets/ButtonInputWidget.less 
b/src/styles/widgets/ButtonInputWidget.less
index 2a7248d..2b13d63 100644
--- a/src/styles/widgets/ButtonInputWidget.less
+++ b/src/styles/widgets/ButtonInputWidget.less
@@ -1,9 +1,6 @@
 @import '../common';
 
 .oo-ui-buttonInputWidget {
-       display: inline-block;
-       vertical-align: middle;
-
        // Reset default browser styles
        > button,
        > input {
diff --git a/src/styles/widgets/ButtonWidget.less 
b/src/styles/widgets/ButtonWidget.less
index c33149f..4fd8918 100644
--- a/src/styles/widgets/ButtonWidget.less
+++ b/src/styles/widgets/ButtonWidget.less
@@ -1,8 +1,5 @@
 @import '../common';
 
 .oo-ui-buttonWidget {
-       display: inline-block;
-       vertical-align: middle;
-
        .theme-oo-ui-buttonWidget();
 }
diff --git a/src/styles/widgets/ToggleButtonWidget.less 
b/src/styles/widgets/ToggleButtonWidget.less
index 5441e4e..943d288 100644
--- a/src/styles/widgets/ToggleButtonWidget.less
+++ b/src/styles/widgets/ToggleButtonWidget.less
@@ -1,8 +1,5 @@
 @import '../common';
 
 .oo-ui-toggleButtonWidget {
-       display: inline-block;
-       vertical-align: middle;
-
        .theme-oo-ui-toggleButtonWidget();
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/305848
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I530008f7f849b1ac7ee8393427d12ec811f19f6a
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <volke...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits