VolkerE has uploaded a new change for review.
https://gerrit.wikimedia.org/r/305877
Change subject: MediaWiki theme: Fix `:hover` state of ComboBoxInputWidget
......................................................................
MediaWiki theme: Fix `:hover` state of ComboBoxInputWidget
Fixing `:hover` state of ComboBoxInputWidget to work when its
IndicatorElement is hovered. Also removing inherited and therefore
duplicated properties from InputWidget and TextInputWidget.
Change-Id: Ib5552f0cb31fa22100bdf72da31cf8cf80e94208
---
M src/styles/widgets/ComboBoxInputWidget.less
M src/themes/mediawiki/widgets.less
2 files changed, 12 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/77/305877/1
diff --git a/src/styles/widgets/ComboBoxInputWidget.less
b/src/styles/widgets/ComboBoxInputWidget.less
index 8d34ac3..4a6babe 100644
--- a/src/styles/widgets/ComboBoxInputWidget.less
+++ b/src/styles/widgets/ComboBoxInputWidget.less
@@ -2,7 +2,6 @@
.oo-ui-comboBoxInputWidget {
display: inline-block;
- position: relative;
&.oo-ui-widget-enabled {
> .oo-ui-indicatorElement-indicator {
diff --git a/src/themes/mediawiki/widgets.less
b/src/themes/mediawiki/widgets.less
index f31185f..52ca4b0 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -723,15 +723,23 @@
}
.theme-oo-ui-comboBoxInputWidget () {
- width: 100%;
- max-width: @max-width-input-default;
-
- .oo-ui-inline-spacing( 0.5em );
+ // inherits from `inputWidget`
input,
textarea {
height: 2.35em;
}
+
+ &.oo-ui-widget-enabled:hover {
+ input,
+ textarea {
+ border-color: @border-color-default-hover;
+
+ &:focus {
+ border-color: @border-color-default-focus;
+ }
+ }
+ }
}
.theme-oo-ui-capsuleMultiselectWidget () {
--
To view, visit https://gerrit.wikimedia.org/r/305877
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib5552f0cb31fa22100bdf72da31cf8cf80e94208
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
