jenkins-bot has submitted this change and it was merged.
Change subject: Make the help button a help link again
......................................................................
Make the help button a help link again
This gives it more visual indicators that it'll take you somewhere. Its
previous frameless-button appearance made it non-obvious that it was behaving
as a link.
Bug: T142484
Change-Id: I7732bf6db7ac63121d6ed1377c654ae8700895d1
---
M modules/ext.templateDataGenerator.ui.js
1 file changed, 9 insertions(+), 9 deletions(-)
Approvals:
Mooeypoo: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ext.templateDataGenerator.ui.js
b/modules/ext.templateDataGenerator.ui.js
index f7dea12..8e4e0e1 100644
--- a/modules/ext.templateDataGenerator.ui.js
+++ b/modules/ext.templateDataGenerator.ui.js
@@ -192,7 +192,7 @@
* current wikitext from.
*/
init: function ( $container, $editorTextbox, userConfig
) {
- var editHelpButtonWidget, relatedPage,
+ var $helpLink, relatedPage,
config = userConfig;
$textbox = $editorTextbox;
@@ -211,13 +211,13 @@
} )
.toggle( false );
- editHelpButtonWidget = new OO.ui.ButtonWidget( {
- label: mw.msg( 'templatedata-helplink'
),
- classes: [
'tdg-editscreen-main-helplink' ],
- href: mw.msg(
'templatedata-helplink-target' ),
- target: '_blank',
- framed: false
- } );
+ $helpLink = $( '<a>' )
+ .attr( {
+ href: mw.msg(
'templatedata-helplink-target' ),
+ target: '_blank'
+ } )
+ .addClass(
'tdg-editscreen-main-helplink' )
+ .text( mw.msg( 'templatedata-helplink'
) );
// Dialog
windowManager = new OO.ui.WindowManager();
@@ -269,7 +269,7 @@
.addClass(
'tdg-editscreen-main' )
.append(
editOpenDialogButton.$element,
-
editHelpButtonWidget.$element,
+ $helpLink,
editNoticeLabel.$element
)
);
--
To view, visit https://gerrit.wikimedia.org/r/304487
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7732bf6db7ac63121d6ed1377c654ae8700895d1
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/TemplateData
Gerrit-Branch: master
Gerrit-Owner: DLynch <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: DLynch <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Mooeypoo <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
