jenkins-bot has submitted this change and it was merged.
Change subject: SelectFileWidget: Remove MIME type information
......................................................................
SelectFileWidget: Remove MIME type information
Removing MIME type information as it's meaningless or even confusing
to majority of users.
Bug: T142883
Change-Id: I18f9aa549869f41119b363e50fef454501792d3f
---
M src/styles/widgets/SelectFileWidget.less
M src/themes/apex/widgets.less
M src/themes/mediawiki/widgets.less
M src/widgets/SelectFileWidget.js
4 files changed, 0 insertions(+), 23 deletions(-)
Approvals:
Prtksxna: Looks good to me, but someone else must approve
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/styles/widgets/SelectFileWidget.less
b/src/styles/widgets/SelectFileWidget.less
index ebf8b13..c9174f2 100644
--- a/src/styles/widgets/SelectFileWidget.less
+++ b/src/styles/widgets/SelectFileWidget.less
@@ -64,10 +64,6 @@
text-overflow: ellipsis;
}
- &-fileType {
- display: none;
- }
-
&-clearButton {
position: absolute;
z-index: 2;
diff --git a/src/themes/apex/widgets.less b/src/themes/apex/widgets.less
index baef495..f9f875b 100644
--- a/src/themes/apex/widgets.less
+++ b/src/themes/apex/widgets.less
@@ -200,12 +200,6 @@
text-overflow: ellipsis;
}
- &-fileType {
- color: #888;
- display: block;
- margin-top: 0.25em;
- }
-
&-clearButton {
top: 0;
right: 0; // With close, no indicator
diff --git a/src/themes/mediawiki/widgets.less
b/src/themes/mediawiki/widgets.less
index afdefcf..a8b196c 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -216,12 +216,6 @@
padding-left: 0.5em;
}
- &-fileType {
- color: #888;
- display: block;
- margin-top: 0.25em;
- }
-
&-clearButton {
top: 0;
right: 0; // With close, no indicator
diff --git a/src/widgets/SelectFileWidget.js b/src/widgets/SelectFileWidget.js
index 58a7f0f..119064d 100644
--- a/src/widgets/SelectFileWidget.js
+++ b/src/widgets/SelectFileWidget.js
@@ -221,13 +221,6 @@
.addClass(
'oo-ui-selectFileWidget-fileName' )
.text( this.currentFile.name )
);
- if ( this.currentFile.type !== '' ) {
- $label = $label.add(
- $( '<span>' )
- .addClass(
'oo-ui-selectFileWidget-fileType' )
- .text( this.currentFile.type )
- );
- }
this.setLabel( $label );
if ( this.showDropTarget ) {
--
To view, visit https://gerrit.wikimedia.org/r/304586
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I18f9aa549869f41119b363e50fef454501792d3f
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: Prtksxna <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
