jenkins-bot has submitted this change and it was merged.

Change subject: Add missing warning parameter
......................................................................


Add missing warning parameter

Change-Id: I03d2d56d56ed754beedc985533791207a12fa97c
---
M pywikibot/family.py
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Xqt: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/pywikibot/family.py b/pywikibot/family.py
index f430048..d05e7a2 100644
--- a/pywikibot/family.py
+++ b/pywikibot/family.py
@@ -934,11 +934,11 @@
             warn(u'Family name %s contains non-ascii characters' % cls.name,
                  FamilyMaintenanceWarning)
         # FIXME: wikisource uses code '-' for www.wikisource.org
-        if not all(all(x in CODE_CHARACTERS for x in code) and
-                   (cls.name == 'wikisource' or code[0] != '-')
-                   for code in cls.langs.keys()):
-            warn(u'Family %s codes contains non-ascii characters',
-                 FamilyMaintenanceWarning)
+        for code in cls.langs.keys():
+            if not all(x in CODE_CHARACTERS for x in code) and \
+                    (cls.name == 'wikisource' or code[0] != '-'):
+                warn('Family %s code %s contains non-ascii characters' %
+                     (cls.name, code), FamilyMaintenanceWarning)
         Family._families[fam] = cls
         return cls
 

-- 
To view, visit https://gerrit.wikimedia.org/r/274605
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I03d2d56d56ed754beedc985533791207a12fa97c
Gerrit-PatchSet: 3
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: GergÅ‘ Tisza <[email protected]>
Gerrit-Reviewer: John Vandenberg <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to